Re: Unified internal communications channel

2023-12-07 Thread Volker Krause
On Donnerstag, 7. Dezember 2023 18:04:24 CET Carl Schwan wrote: > On Thursday, December 7, 2023 4:15:36?PM CET Nate Graham wrote: > > What I'm proposing is some kind of place that *only* has internal > > announcements and is very log signal-to-noise such that we can > > fearlessly recommend that

Re: Frameworks 6 Branching

2022-12-20 Thread Volker Krause
On Montag, 19. Dezember 2022 15:39:07 CET Fusion Future wrote: > On 2022/12/19 20:17, Volker Krause wrote: > > From that point on, KDE Frameworks 5 is considered feature-frozen, > > feature > > > > work should continue to happen in the master branch, primarily target

Frameworks 6 Branching

2022-12-19 Thread Volker Krause
Hello everyone (and sorry for the massive cross-posting), we are nearing an important milestone in the KDE Frameworks 6 development, branching and thus splitting the development of KDE Frameworks 5 and 6. Slightly behind the plan from Akademy this is currently scheduled for the first week of

KF6 meeting notes 2022-04-26

2022-04-26 Thread Volker Krause
(cc-ing Plasma as well, as it's actually mostly about that this time) https://invent.kde.org/teams/frameworks-devs/kf6-workboard/-/issues/4 Remaining QDesktopWidget uses: * KAccess: - this is an accessibility feature for showing the X11 bell visually, from a separate program - needs figuring

Re: CI Repairs

2022-03-08 Thread Volker Krause
On Dienstag, 8. März 2022 08:54:38 CET Ben Cooksley wrote: > This evening i've repaired several issues that were causing builds to fail > on the main Jenkins CI system. This includes a broken Windows builder > (causing Windows builds to periodically fail) and a hung FreeBSD builder > (which was

Re: KEmoticons, emoticons kcm

2020-05-23 Thread Volker Krause
On Saturday, 23 May 2020 02:49:57 CEST Aleix Pol wrote: > I was looking through some Plasma code and I saw that we have some > fairly old emoticons KCM using KF5Emoticons. > > Now while I know why this exists, it feels like it's more of a thing > of the past from when people wrote :) instead of

D29478: [Clipboard Plasmoid] Port to Prison QML import

2020-05-06 Thread Volker Krause
vkrause added a comment. Technically this looks fine from the Prison POV. Whether the barcode type selection makes sense beyond "because we can" I'm not sure about though (in particular the 1D codes seem to be of questionable use here), but then again that's not something introduced by this

D29268: [WIP] Add Date/Time dialog

2020-04-29 Thread Volker Krause
vkrause added a comment. There might be ways around the native function registration issue from the QML thread, e.g. by using the alternative approach of exported (mangled) symbols instead: https://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/design.html -> "Loading and Linking Native

D27595: Watch for language change events, and forward those to the QML engine

2020-03-28 Thread Volker Krause
vkrause added subscribers: broulik, davidedmundson. vkrause added a comment. In D27595#636543 , @rikmills wrote: > git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 I haven't seen a

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION

D27595: Watch for language change events, and forward those to the QML engine

2020-03-04 Thread Volker Krause
vkrause added a comment. I can reproduce only if I set a valid translation catalog. Even more surprising since the affected dialog does not seem to contain any qsTr() translations. I don't think this patch is wrong as such, the layouting glitch is a bug elsewhere that we trigger by the

D27595: Watch for language change events, and forward those to the QML engine

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b7cae898ed7: Watch for language change events, and forward those to the QML engine (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27525: Support Qt 5.14 on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:8bf5b4675186: Support Qt 5.14 on Android (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27525?vs=76060=76477 REVISION DETAIL

D27595: Watch for language change events, and forward those to the QML engine

2020-02-24 Thread Volker Krause
vkrause added a comment. In D27595#616544 , @apol wrote: > I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. Right, or at least in QQmlApplicationEngine. REPOSITORY

D27606: Remove usage of KDBusConnectionPool

2020-02-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R161:fa5b3bb382ac: Remove usage of KDBusConnectionPool (authored by vkrause). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27606?vs=76237=76248

D27606: Remove usage of KDBusConnectionPool

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly in a

D27595: Watch for language change events, and forward those to the QML engine

2020-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes a race condition on startup for the Kirigami translation catalog that happens as follows: - QML code triggers

D27525: Support Qt 5.14 on Android

2020-02-21 Thread Volker Krause
vkrause added a comment. In D27525#614905 , @apol wrote: > > Assets (QML files and icons) are no longer extracted into the file system, > > but now are available in the android_rcc_bundle QRC file. > > Meaning that we now need to change

D27525: Support Qt 5.14 on Android

2020-02-20 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Assets (QML files and icons) are no longer extracted into the file system, but now are available in the android_rcc_bundle QRC

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R128:39ce0e82856e: Port away from KIconThemes (authored by vkrause). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26072?vs=71738=71745 REVISION DETAIL

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This was only using the deprecated IconSize() method. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

Re: KF6 Sprint

2019-10-30 Thread Volker Krause
CET Volker Krause wrote: > Hi, > > as you might have seen in David's summary of the KF6 BoF at Akademy > (https:// > mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), > there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we > had in R

D24603: Port away from deprecated KDELibs4Support

2019-10-13 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. Thanks! REPOSITORY R103 KMenu Editor BRANCH master REVISION DETAIL https://phabricator.kde.org/D24603 To: ahmadsamir, mlaurent, vkrause Cc: vkrause, plasma-devel, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23821: Clean up a few deprecated headers, and make dependencies more explicit

2019-09-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R119:6529788d5e07: Clean up a few deprecated headers, and make dependencies more explicit (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23821?vs=65727=66314#toc REPOSITORY

D5961: PoC: Generic adoption of KUserFeedback for Discover

2019-09-17 Thread Volker Krause
vkrause added a comment. +1 INLINE COMMENTS > DiscoverWindow.qml:71 > +surveyInterval: 30 > +feedbackServer: "http://localhost:8083/; > +encouragementInterval: 30 https://telemetry.kde.org/ REPOSITORY R134 Discover Software Store REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

2019-09-17 Thread Volker Krause
vkrause added a comment. In D24011#533038 , @broulik wrote: > Should we make it already a "Privacy" KCM just in case? I'm not convinced about that. "Privacy" is not something you need to enable (it's on by default), and it's not

KF6 Sprint

2019-09-15 Thread Volker Krause
Hi, as you might have seen in David's summary of the KF6 BoF at Akademy (https:// mail.kde.org/pipermail/kde-frameworks-devel/2019-September/093298.html), there's the idea to have a KF6 sprint, along the lines of the KF5 sprint we had in Randa a few years back, to determine what we actually

D23818: Port away from kdemacros.h

2019-09-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R101:7f6ab9fe5b96: Port away from kdemacros.h (authored by vkrause). REPOSITORY R101 KHotKeys CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23818?vs=65723=65774 REVISION DETAIL

D23821: Clean up a few deprecated headers, and make dependencies more explicit

2019-09-10 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: plasma-devel. Herald added a project: Plasma. vkrause requested review of this revision. REVISION SUMMARY Side effect from trying to figure out what needs to be done for T11568 . REPOSITORY R119

D23799: Get rid of khtml usage (kill classic mode)

2019-09-10 Thread Volker Krause
vkrause added a comment. In D23799#527953 , @ognarb wrote: > +1 > is there a task somewhere where we can track all the KDE projects still using khtml? T11542 tracks KHTML specifically, and it's

D23818: Port away from kdemacros.h

2019-09-10 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: plasma-devel. Herald added a project: Plasma. vkrause requested review of this revision. REPOSITORY R101 KHotKeys BRANCH master REVISION DETAIL https://phabricator.kde.org/D23818 AFFECTED FILES

D23799: Get rid of khtml usage (kill classic mode)

2019-09-09 Thread Volker Krause
vkrause added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23799 To: svuorela, vkrause, plasma-devel Cc: sitter, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23188: Fix supported OS attributes for api.kde.org

2019-08-19 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c67827d4274f: Fix supported OS attributes for api.kde.org (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23188?vs=63822=64058 REVISION

D23188: Fix supported OS attributes for api.kde.org

2019-08-18 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in metainfo.yaml:12 > Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to > change elsewhere? See commit message, yes. We'd need to change it everywhere in order to show up as a single "macOS" entry on

D23188: Fix supported OS attributes for api.kde.org

2019-08-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Move the "maintainer needed" to a note, so it's not showing up globally for all modules. Also, change "macOS" back to "MacOSX"

Re: KInit - Current state and benchmarks

2019-06-17 Thread Volker Krause
Thanks for the very interesting and useful research! On Monday, 17 June 2019 11:56:15 CEST David Edmundson wrote: > From API.kde.org: > >Using kdeinit to launch KDE applications makes starting a typical KDE > >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) > Certainly

D21399: Compress color changes without a QTimer

2019-05-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:e5a6ac33f787: Compress color changes without a QTimer (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21399?vs=58644=58679 REVISION DETAIL

D21399: Compress color changes without a QTimer

2019-05-25 Thread Volker Krause
vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This class exists in large quantities, so this avoids creating hundreds of QTimer instances just for the signal compression.

D20132: Actually make the network list view show up

2019-04-01 Thread Volker Krause
vkrause added a comment. Maybe that's the relevant difference already, I have only been testing within plasma-settings, need to retest with kcmshell directly. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich Cc:

D20132: Actually make the network list view show up

2019-04-01 Thread Volker Krause
vkrause added a comment. With that the network list had 0 width and was thus invisible for me, both on desktop and on yocto/rpi, using Qt 5.11 and latest Kirigami. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20132 To: vkrause, jgrulich

Re: CI system maintainability

2019-03-30 Thread Volker Krause
On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > I fear that a mandatory reviews would add too juch strain on smaller > > teams. If there's just one person with an intimate knowledge of the > > code-base, plus two co-developers,

Re: CI system maintainability

2019-03-29 Thread Volker Krause
On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > Having mandatory reviews for a central and complex component like akonadi > > looks like a very good and obvious idea. > > Yep. Looking at the 18.12 -> 19.04

Re: CI system maintainability

2019-03-28 Thread Volker Krause
On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I will not wait several days for a > >

Re: CI system maintainability

2019-03-28 Thread Volker Krause
On Thursday, 28 March 2019 16:32:34 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto: > > In this case, it seems like the problem is that there are certain > > individuals or teams that are pushing risky, breaking changes without code > > review, and

Re: CI system maintainability

2019-03-28 Thread Volker Krause
On Thursday, 28 March 2019 09:50:47 CET Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > > > at your screen or pair with you" in the past. Clearly this compromise > > > gets > >

D20014: Update URLs to use https

2019-03-25 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R134:428f4171c494: Update URLs to use https (authored by vkrause). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20014?vs=54654=54795 REVISION DETAIL

D20014: Update URLs to use https

2019-03-24 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Also update one URL that no longer works. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL

D19995: Change URLs to https where possible

2019-03-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fc6cdb161516: Change URLs to https where possible (authored by vkrause). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19995?vs=54610=54624 REVISION

D19997: Change http URLs to https

2019-03-23 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R845:a73e803a39f3: Change http URLs to https (authored by vkrause). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19997?vs=54616=54623 REVISION DETAIL

D19997: Change http URLs to https

2019-03-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL https://phabricator.kde.org/D19997 AFFECTED FILES

D19995: Change URLs to https where possible

2019-03-23 Thread Volker Krause
vkrause created this revision. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Also, update a few outdated or redirecting URLs. REPOSITORY R119 Plasma Desktop BRANCH master

D19894: Use https for links in the UI

2019-03-20 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R871:f6eb9ba3dd92: Use https for links in the UI (authored by vkrause). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19894?vs=54355=54432 REVISION DETAIL

D19894: Use https for links in the UI

2019-03-19 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D19894 AFFECTED FILES src/aboutbugreportingdialog.cpp

D19465: Port to ECM's component/imported target based FindXCB

2019-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R119:8c28ac839ad5: Port to ECMs component/imported target based FindXCB (authored by vkrause). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19463: Use FindGLIB2 from ECM

2019-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R115:0b1559c47c3a: Use FindGLIB2 from ECM (authored by vkrause). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19463?vs=52944=53157 REVISION DETAIL

D19465: Port to ECM's component/imported target based FindXCB

2019-03-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19465 AFFECTED FILES

D19463: Use FindGLIB2 from ECM

2019-03-02 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D19463 AFFECTED FILES

D19247: Replace outdated FindX11_XCB copy with ECM and imported targets

2019-02-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R119:45d35e88b3cd: Replace outdated FindX11_XCB copy with ECM and imported targets (authored by vkrause). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19244: Remove outdated FindGLIB2 copy

2019-02-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R119:f88abed5581f: Remove outdated FindGLIB2 copy (authored by vkrause). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19244?vs=52365=52428 REVISION DETAIL

D19247: Replace outdated FindX11_XCB copy with ECM and imported targets

2019-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19247 AFFECTED FILES

D19244: Remove outdated FindGLIB2 copy

2019-02-23 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This is provided by ECM nowadays, with proper imported targets. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D17079: Provide a qqc2/kirigami-based about page

2018-11-24 Thread Volker Krause
vkrause added a comment. In D17079#364308 , @mart wrote: > In D17079#364263 , @apol wrote: > > > In D17079#364163 , @ltoscano wrote: > > > > >

D14976: Less aggessive monochroming of icons

2018-08-22 Thread Volker Krause
vkrause added a comment. Thanks! This looks like it should fix my problem with the breeze weather icons on Android :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D14976 To: mart, #kirigami, vkrause Cc: plasma-devel, apol, davidedmundson, mart, hein

D13874: textplugin: Fix missing QTextStream include

2018-07-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R112:6b2036cb8a1d: textplugin: Fix missing QTextStream include (authored by alistairf, committed by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13874?vs=37123=37982#toc REPOSITORY

D14129: Port away from string-based connects

2018-07-16 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R858:e1ccdc1d7698: Port away from string-based connects (authored by vkrause). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D14129: Port away from string-based connects

2018-07-15 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Due to the large amount of connections here, multiplied by the not exactly small amount of

D13932: Show icons for actions that have an icon source rather than an icon name

2018-07-10 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R169:1454366a2e33: Show icons for actions that have an icon source rather than an icon name (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D13932: Show icons for actions that have an icon source rather than an icon name

2018-07-07 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13932 AFFECTED FILES

D13811: Add license files

2018-06-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R97:c9e283a7f14f: Add license files (authored by vkrause). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13811?vs=36942=36957 REVISION DETAIL

D13811: Add license files

2018-06-30 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Yocto's license check complains if those are missing. REPOSITORY R97 Bluedevil BRANCH master

D10560: [Clipboard plasmoid] Support Aztec barcode

2018-02-16 Thread Volker Krause
vkrause added a comment. looks good to me REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10560 To: broulik, #plasma, graesslin, vkrause Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D9991: Remove unnecessary dependency on QtScript

2018-01-20 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R112:684a95a6ef0b: Remove unnecessary dependency on QtScript (authored by vkrause). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9991?vs=25682=25683 REVISION DETAIL

D9991: Remove unnecessary dependency on QtScript

2018-01-20 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. vkrause requested review of this revision. REPOSITORY R112 Milou BRANCH master REVISION DETAIL

Re: qqc2-desktop-style as framework

2017-10-14 Thread Volker Krause
On Thursday, 31 August 2017 17:06:46 CEST Marco Martin wrote: > Hi all, > we have a qtquickcontrols style that is right now in workspace (unrelased, > to be released with Plasma 5.11) > it makes controls paint with qstyle to give it a reasonable desktop > appearance, plus some fixes/workarounds to

D5961: PoC: Generic adoption of KUserFeedback for Discover

2017-06-19 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > CMakeLists.txt:30 > > +find_package(UserFeedback) > + Hm, looks like I forgot to rename this to KUserFeedback... Should probably done to be consistent with naming elsewhere. I'll look into it, and sorry for yet another SC change. >

Re: Review Request 125195: Update the GTK icon cache when installing.

2015-09-14 Thread Volker Krause
marked as submitted. Review request for Plasma and Olivier Goffart. Changes --- Submitted with commit 92cd2b667c04e18fd66986e8a42a53c052f5b5a0 by Volker Krause to branch master. Repository: breeze Description --- Despite the name this is also used by Qt, and considerably speeds up

Review Request 125195: Update the GTK icon cache when installing.

2015-09-12 Thread Volker Krause
/CMakeLists.txt 814b5ade4e5d185120a47fb72f2d5f531a7e8d41 Diff: https://git.reviewboard.kde.org/r/125195/diff/ Testing --- Installed with and without existing cache, cache is correctly updated and ends up in the expected place. Thanks, Volker Krause

Re: Review Request 120181: Remove usage of the obsolete Akonadi MicroBlog stuff.

2014-09-14 Thread Volker Krause
780deaae92f4732a1f1b8372a2c4f55cf21751c7 dataengines/akonadi/akonadiengine.cpp 89fee441e579f15722b89427939ab40facd49fc8 Diff: https://git.reviewboard.kde.org/r/120181/diff/ Testing --- Thanks, Volker Krause ___ Plasma-devel mailing list Plasma-devel

Review Request 120181: Remove usage of the obsolete Akonadi MicroBlog stuff.

2014-09-13 Thread Volker Krause
89fee441e579f15722b89427939ab40facd49fc8 Diff: https://git.reviewboard.kde.org/r/120181/diff/ Testing --- Thanks, Volker Krause ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Volker Krause
On Friday 20 July 2012 17:58:04 Martin Gräßlin wrote: Hi all, the problems around review request #105628 and getting KWallet's Password dialog properly raised above the window it is asking the password for just triggered a thought process. The main problem here is that $service ask for a

Re: [Kde-pim] Akademy2012 BoF for WebAccounts

2012-06-25 Thread Volker Krause
On Saturday 23 June 2012 18:09:34 Alex Fiestas wrote: On Saturday, June 23, 2012 10:32:05 AM Volker Krause wrote: Monday might be tricky for me though, I'll be involved in running the Qt Quick 2 workshop there, but attending at least parts of this should be doable. Which time works best

Re: [Kde-pim] Akademy2012 BoF for WebAccounts

2012-06-23 Thread Volker Krause
On Friday 22 June 2012 16:08:25 Martin Klapetek wrote: On Thu, Jun 21, 2012 at 5:01 PM, Alex Fiestas afies...@kde.org wrote: Hi there! Sorry for the cross-posting, but this is a topic actually affecting all three mailist. Would be awesome to have a BoF at Akademy2012 about

Re: Re: KDE-ify QML all across KDE

2011-01-27 Thread Volker Krause
On Thursday 27 January 2011 13:39:40 Shantanu Tushar Jha wrote: Hi Marco, I'm am working on Calligra Mobile as an Intern at Nokia. Just remembered that you had sent this mail. I understand that libkdeclarative is planned to be *the* way to access essential kdelibs functionality. If so, I was