[frameworks-plasma] [Bug 457079] Remove "&" character from tooltip from Configure File Launcher icon

2022-07-24 Thread Andreas Sturmlechner
https://bugs.kde.org/show_bug.cgi?id=457079 Andreas Sturmlechner changed: What|Removed |Added CC||ast...@gentoo.org --- Comment #2 from

Toolchain Helper Tools for Cross-Compiling

2022-02-28 Thread Andreas Cord-Landwehr
"ONLY_BUILD_HOST_TOOLS" My personal favorite is probably b) because it looks to me to be the least amount of refactoring. I am looking forward to what you think! Cheers, Andreas

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2020-09-16 Thread Andreas Sturmlechner
asturmlechner added a comment. In D23883#530551 , @davidedmundson wrote: > It only exists as a hack around some Qt5.9(?) bug to allow plasma stuff to be in wayland without needing us to force an environment variable. > Personally I want to

Re: Plasma 5.20 and Qt versions

2020-06-15 Thread Andreas Sturmlechner
f as well as do some big code cleanup. No problem for Gentoo, Qt 5.15.0 is available since release day and will be stable in ~2 months together with Release Service 20.04.3 and after fixing all other consumers. Regards, Andreas

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner added a comment. In D29514#665912 , @ngraham wrote: > In D29514#665911 , @asturmlechner wrote: > > > In D29514#665869 , @ngraham wrote: >

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: Where is synaptics-properties.h located on

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

2020-05-07 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY x11 backend of the touchpad KCM uses xserver-properties.h that is part of

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29215 To: asturmlechner, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29215: synapticstouchpad.cpp: Drop synaptics-properties.h parent dir from include

2020-04-26 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY Otherwise, this does not get the header from Synaptics_INCLUDE_DIRS. TEST PLAN

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

2020-04-12 Thread Andreas Sturmlechner
asturmlechner added a comment. Thanks for keeping pipewire optional, this is in line with how we have been packaging xdg-desktop-portal-kde in Gentoo so far, we had just been conditionally disabling the cmake finding of these 3 libraries to do it, and will switch over to using the new

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

2020-03-29 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R858:d2f44e46e758: QQC2-Desktop-Style: Convert license headers to SPDX expressions (authored by cordlandwehr). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28382: QQC2-Desktop-Style: Convert license headers to SPDX expressions

2020-03-28 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license texts as required by REUSE specification. REPOSITORY

D27435: Move checked menu item always into range

2020-02-26 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:cd124d4251f6: Move checked menu item always into range (authored by cordlandwehr). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27435?vs=75780=76486#toc REPOSITORY R169 Kirigami CHANGES

D27364: Kirigami: Convert license headers to SPDX markers

2020-02-26 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:8d09d66f5fd3: Kirigami: Convert license headers to SPDX markers (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27364?vs=75595=76484

D27364: Kirigami: Convert license headers to SPDX markers

2020-02-26 Thread Andreas Cord-Landwehr
cordlandwehr added a comment. @mart the main argument chain here is: we need machine readable license identifiers to enable tooling -> SPDX markers are the way to go -> having both license statements and SPDX markers in the same file will ultimately lead to ambiguous licenses, since people

D27435: Move checked menu item always into range

2020-02-16 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY This allows to use backend logic, which e.g. has next/previous buttons to

D27364: Kirigami: Convert license headers to SPDX markers

2020-02-13 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX markers and add license files as required by REUSE specification. REPOSITORY

D27251: Relicense to LGPL-2.0-or-later

2020-02-10 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:3f55e64993f9: Relicense to LGPL-2.0-or-later (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27251?vs=75259=75390 REVISION DETAIL

D27264: Fix tabbar width computation

2020-02-09 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c31e7ea68957: Fix tabbar width computation (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27264?vs=75299=75300 REVISION DETAIL

D27264: Fix typo in Math call

2020-02-09 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REPOSITORY R169 Kirigami BRANCH bugfix/widthComputation REVISION DETAIL

D27251: Relicense to LGPL-2.0-or-later

2020-02-08 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. cordlandwehr added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Request to Marco to relicense both files to the license LGPL-2.0-or-later, which

D26185: Also disable automatic scaling on Qt >= 5.14

2020-01-21 Thread Andreas Hartmetz
ahartmetz added a comment. @fvogt Yeah thanks, that made more sense than you spoon-feeding me the information for the commit message ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson, fvogt Cc:

D26185: Fix font rendering when compiled against Qt >= 5.14

2020-01-16 Thread Andreas Hartmetz
ahartmetz added a comment. So what do we do here? The Qt bug has been fixed but still I'm not sure what should be done about the environment variables. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc:

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-29 Thread Andreas Hartmetz
ahartmetz added a comment. In D26185#584249 , @davidedmundson wrote: > Thanks for following up! > > > I'll open a Qt bug and see how it goes. > > Can you link it please. Somebody was faster. I added a comment and a link to this

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-28 Thread Andreas Hartmetz
ahartmetz added a comment. In D26185#583991 , @anthonyfieroni wrote: > Can forcing bigger font DPI make things better? AFAICS no. If scaling is conceptually enabled, i.e. if an application //would// be scaled //if// you attached a high

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-28 Thread Andreas Hartmetz
ahartmetz added a comment. It's probably okay to still say that scaling is enabled "in general" but for scaling <2, and why not, maybe even greater, hinting should not be inhibited. The screen is still made of pixels. Qt is not going to be able to throw out all the hinting and subpixel code

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-28 Thread Andreas Hartmetz
ahartmetz added a comment. I think I see the problem. You pay for the //possibility// to have scaling with unhinted fonts. I am pretty sure that that isn't an acceptable way of handling it. Most Linux desktop fonts are intended to be used with some hinting (slight hinting usually?).

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-24 Thread Andreas Hartmetz
ahartmetz added a comment. Just to make this extra clear, I have nothing against auto-scaling. There is probably a KCM to set it however I want if I don't like the default. My problem is with blurry and in some cases ("-=") disfigured font rendering. That should never happen regardless of

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz
ahartmetz added a comment. In D26185#582095 , @anthonyfieroni wrote: > Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ That unfortunately does not seem to help. I set the environment in a shell inside

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz
ahartmetz added a comment. Compiled against Qt 5.14 before this change: F7832282: before.png Compiled against Qt 5.14 after this change: F7832284: after.png REPOSITORY R120 Plasma Workspace REVISION

D26185: Fix font rendering when compiled against Qt >= 5.14

2019-12-23 Thread Andreas Hartmetz
ahartmetz created this revision. ahartmetz added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahartmetz requested review of this revision. REVISION SUMMARY Whatever behavior change was apparently expected in Qt 5.14 didn't happen. I compiled

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-16 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson, fvogt, ngraham Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner added a comment. In D22210#547637 , @davidedmundson wrote: > 1. A period where both X and wayland say "Plasma". > > 1 is super super bad. Which means we need to patch one of the Plasma entries first. I would block this

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 67992. asturmlechner added a comment. Switch back to Plasma (Wayland) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=62165=67992 BRANCH arcpatch-D22210 REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-10-15 Thread Andreas Sturmlechner
asturmlechner added a comment. In D22210#547621 , @ngraham wrote: > "Plasma on Xorg" is a yucky string to display to users. well, it is what Gnome apparently does, so at least it would have lead to some uniformity. But no strong opinion

D23883: libkworkspace: Install sessionmanagementbackend.h with other headers

2019-09-12 Thread Andreas Sturmlechner
asturmlechner added a comment. copy that for Gentoo. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23883 To: heikobecker, #plasma Cc: davidedmundson, asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23148: Add missing headers with DISABLE_MODEMMANAGER_SUPPORT=ON

2019-08-14 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23148 To: asturmlechner, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D23148: Add missing headers

2019-08-14 Thread Andreas Sturmlechner
asturmlechner created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. asturmlechner requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-21 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 62165. asturmlechner added a comment. drop translations, rename to 'Plasma on Xorg' REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22210?vs=60995=62165 BRANCH session-rename REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-20 Thread Andreas Sturmlechner
asturmlechner added a comment. FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter,

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-15 Thread Andreas Sturmlechner
asturmlechner added a comment. I'll have to do this downstream, anyway... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

2019-07-04 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4dcd1588c1cf: doc: Some different phrasing, one instance of s/KDE/Plasma/ (authored by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

2019-07-02 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added projects: Plasma, Documentation. Herald added subscribers: kde-doc-english, plasma-devel. asturmlechner requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-02 Thread Andreas Sturmlechner
asturmlechner added a comment. Well, what's the current situation - SDDM have made the decision on their part to append that tech-garbage for Wayland sessions, users end up with: - Plasma - Plasma (Wayland) Per linked issue it is not going to be like that forever; on every(?)

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

2019-07-02 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it

D19011: Thunderbolt KCM and KDED module

2019-06-18 Thread Andreas Sturmlechner
asturmlechner added a comment. In D19011#480868 , @ngraham wrote: > and we should lobby distros to ship with the new repo/package. Provide a tarball and I'll gladly turn our git master ebuild into a release ebuild. ;) REPOSITORY R119

D8626: DDCUtil: Improved DDCUtil support for brightness control

2019-04-03 Thread Andreas Sturmlechner
asturmlechner added a comment. Hm, any reason why this is still pending? REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D8626 To: dvogel, broulik, davidedmundson Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19654: Add lazy instantiation for submenus

2019-03-11 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R169:d06e7280045d: Add lazy instantiation for submenus (authored by cordlandwehr). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19654?vs=53596=53688 REVISION DETAIL

D19654: Add lazy instantiation for submenus

2019-03-10 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Items of submenus are only required when the respective submenu is becoming visible. Setting the intantiator to

D18361: libkworkspace: Allow standalone build

2019-01-18 Thread Andreas Sturmlechner
asturmlechner added a comment. For the record, I would have been in support of this. ;) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18361 To: heikobecker Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D14147: Port from GConf to GSettings

2019-01-14 Thread Andreas Sturmlechner
asturmlechner added inline comments. INLINE COMMENTS > drosca wrote in CMakeLists.txt:46 > This should probably use cache variables: > > set(USE_GCONF FALSE CACHE STRING "Build with GConf") > set(USE_GSETTINGS TRUE CACHE STRING "Build with GSettings") this still needs to be addressed,

D16550: [ksmserver] Fix session restore check

2018-10-31 Thread Andreas Hartmetz
ahartmetz accepted this revision. ahartmetz added a comment. This revision is now accepted and ready to land. This fixes session restore for me. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16550 To: davidedmundson, ahartmetz Cc:

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R116:6919a84c70d8: openconnect: add missing dependency Qt5Xml (authored by asturmlechner). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner added a comment. In D16073#340107 , @alexeymin wrote: > If it fixes build error `.../vpn/openconnect/openconnectauth.cpp:38:10: fatal error: QDomDocument: No such file or directory` then fine... Yes, it was exactly that:

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 43221. asturmlechner added a comment. Only pull in Qt5Xml if OpenConnect is requested. REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16073?vs=43220=43221 BRANCH Plasma/5.14 REVISION

D16073: openconnect: add missing dependency Qt5Xml

2018-10-09 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY QDomDocument is imported from vpn/openconnect/openconnectauth.cpp TEST PLAN

D15435: Add translucent background attribute to desktop icon popup menu

2018-09-12 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc47b95094a3: Add translucent background attribute to desktop icon popup menu (authored by anemeth, committed by asturmlechner). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[kio-extras] [Bug 375826] Copying files to a remote SFTP folder opens a popup "Could not change permissions.."

2018-09-02 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=375826 Andreas Schneider changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO Resolution

[kio-extras] [Bug 368877] log_kio_sftp log flood

2018-09-02 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=368877 Andreas Schneider changed: What|Removed |Added Assignee|plasma-devel@kde.org|a...@cryptomilk.org CC

[kio-extras] [Bug 375305] SFTP file create date is wrong

2018-09-02 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=375305 Andreas Schneider changed: What|Removed |Added CC||a...@cryptomilk.org Assignee

[kio-extras] [Bug 362988] sftp connection win dolphin hangs/stops working after few seconds

2018-09-02 Thread Andreas Schneider
https://bugs.kde.org/show_bug.cgi?id=362988 Andreas Schneider changed: What|Removed |Added Ever confirmed|0 |1 CC

D14326: Fix layout of resolution selection

2018-07-24 Thread Andreas Kainz
andreaska added a comment. The thing is that you should bring more focus to the screen factor setting. Ordinary you should not change the screen resolution you should change the factor on hidpi this should be in focus. Nobody should change the resolution and the rate by default cause best

D14325: Remove Advanced section from screen config

2018-07-24 Thread Andreas Kainz
andreaska added a comment. Will be useful. Can you make the dropdown items all the same size. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14325 To: gladhorn, #plasma, #vdg Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-07-18 Thread Andreas Sturmlechner
asturmlechner added a comment. ping - could we get this in for 5.14? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol Cc: tfoster, apol, asturmlechner, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13694: Fix wrong availability of profiles and ports.

2018-06-27 Thread Andreas Krutzler
akrutzler added a comment. Good. :) I don't have commit rights yet so I think I can't do it there. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To: akrutzler, nicolasfella, broulik, drosca Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler updated this revision to Diff 36728. akrutzler added a comment. Implement `setInfo` function for each, the `Port` and `Profile` class. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36717=36728 BRANCH

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler added a comment. My patched version of the plugin for the KCM wasn't loaded correctly, that's why I saw the same results. I'm still struggling developing KDE libs/plugins but it's getting better :) I solved the problem by implementing the `setInfo` function for each, the

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler updated this revision to Diff 36717. akrutzler added a comment. Accept profiles which are not unavailable. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13694?vs=36558=36717 BRANCH fix_wrong_availability REVISION DETAIL

D13694: Fix wrong availability of profiles and ports.

2018-06-26 Thread Andreas Krutzler
akrutzler added a comment. In D13694#282499 , @nicolasfella wrote: > This breaks the profile selection Combobox in the KCM. I'm sorry to hear that, on my system I get the same results as in the released kcm. In D13694#282499

D13696: Handle enabled property of simple models

2018-06-25 Thread Andreas Cord-Landwehr
cordlandwehr closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D13696 To: cordlandwehr, mart Cc: plasma-devel, apol, davidedmundson, mart, hein

D13696: Handle enabled property of simple models

2018-06-24 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 36591. cordlandwehr added a comment. Fixed logical error REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13696?vs=36560=36591 BRANCH handleUndefinedModelEnabled (branched from master) REVISION DETAIL

D13696: Handle enabled property of simple models

2018-06-23 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Models without a specific "enabled" role have to fall back to the modelData property.

D13694: Fix wrong availability of profiles and ports.

2018-06-23 Thread Andreas Krutzler
akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY Fixed bug where available ports are displayed as unavailable/unplugged and vice versa. It

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-12 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt optional (authored by arfrever, committed by asturmlechner). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-11 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 35985. asturmlechner added a comment. Use Q_UNUSED REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35896=35985 BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255

D13255: Make dependency on KF5NetworkManagerQt optional

2018-06-09 Thread Andreas Sturmlechner
asturmlechner updated this revision to Diff 35896. asturmlechner added a comment. Update addressing 2/3 points raised REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35291=35896 BRANCH master REVISION DETAIL

D13435: Remove verbose debugging statement

2018-06-08 Thread Andreas Hartmetz
ahartmetz accepted this revision. ahartmetz added a comment. There are many more plain qDebug()s in this module, but this one seems to produce the most noise... REPOSITORY R101 KHotKeys BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D13435 To: fvogt, #plasma,

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner
asturmlechner added a comment. (this is me forwarding a Gentoo user contribution) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13255: Make dependency on KF5NetworkManagerQt optional

2018-05-31 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH Plasma/5.13

D13188: Respect libdir for Firefox native messaging host manifest

2018-05-29 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R856 Plasma Browser Integration BRANCH Plasma/5.13

D13006: Move the inline installer progress cancel button to the left side

2018-05-20 Thread Andreas Kainz
andreaska added a comment. Thanks +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D13006 To: ngraham, apol, #discover_software_store Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D12547: Fix build with Qt 5.11 (missing QStyle)

2018-04-26 Thread Andreas Sturmlechner
asturmlechner closed this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D12547 To: asturmlechner, #plasma, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12547: Fix build with Qt 5.11 (missing QStyle)

2018-04-26 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY Necessary after 6a9df821

D11794: Drop unused dependency

2018-03-30 Thread Andreas Sturmlechner
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0a349abccb5f: Drop unused dependency (authored by asturmlechner). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11794?vs=30887=30917 REVISION DETAIL

D11794: Drop unused dependency

2018-03-29 Thread Andreas Sturmlechner
asturmlechner created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D11794

D11413: Fix build with Qt 5.11 (missing headers)

2018-03-19 Thread Andreas Sturmlechner
asturmlechner abandoned this revision. asturmlechner added a comment. Obsolete by f83d0336a875f04361acb714c2eab490335d8d88 REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D11413 To:

D11413: Fix build with Qt 5.11 (missing headers)

2018-03-17 Thread Andreas Sturmlechner
asturmlechner created this revision. asturmlechner added a reviewer: ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL

D11063: [mediacontroller applet] Reorder elements

2018-03-06 Thread Andreas Kainz
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStructure REVISION DETAIL https://phabricator.kde.org/D11063 To: romangg, #plasma, andreask Cc: nicolasfella, broulik, plasma-devel, ZrenBot, lesliezhai,

D11056: [mediacontroller applet] Use media playback status icons

2018-03-06 Thread Andreas Kainz
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH mediaAppletStatusIcon REVISION DETAIL https://phabricator.kde.org/D11056 To: romangg, #plasma, andreask Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-02 Thread Andreas Kainz
andreask added a comment. the patches you linked are for breeze-icons. They are fine and will work. Here we are in plasma-framework in the breeze plasma theme that is complete separate and in plasma framework the change didn't go to master.

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-02 Thread Andreas Kainz
andreask added a comment. I'm that much confuse maybe someone can make a screenshot what should be changed the opacity was already changed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas,

D10243: Improve visibility of disconnected Wi-Fi icons

2018-03-02 Thread Andreas Kainz
andreask added a comment. F5736934: network.svgz sorry I'm not the maintainer for the breeze plasma theme and arc isn't my friend so I upload the svg file with the red color here. If someone want to have the ? in read than push it to master.

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-21 Thread Andreas Krutzler
akrutzler updated this revision to Diff 27724. akrutzler added a comment. Rebase to origin/Plasma/5.12. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10701?vs=27642=27724 BRANCH diffD10701 REVISION DETAIL

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler added a comment. Not yet, @ngraham did all the commits for me so far. Just in case, my email is andreas.krutz...@gmx.net :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler added a comment. The gifs were the hardest part :) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham, #discover_software_store Cc: acrouthamel, plasma-devel, ZrenBot, lesliezhai,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler edited the summary of this revision. akrutzler added reviewers: apol, ngraham. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10701 To: akrutzler, apol, ngraham Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10701: Fix ApplicationScreenshots shadow for Breeze Dark.

2018-02-20 Thread Andreas Krutzler
akrutzler created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. akrutzler requested review of this revision. REVISION SUMMARY If you're using Breeze Dark or probably any other dark theme, the screenshot shadow-gradient

D10541: make kdesu available in bindir and thus $PATH by default (opt-out)

2018-02-15 Thread Andreas Sturmlechner
asturmlechner added a comment. > (so as to not conflict with kdelibs4's kdesu). I don't think you need to care about conflicts with kde-runtime at this point. There is no reason why on a Plasma-5 system the old binary should be present as it works like a drop-in replacement. REPOSITORY

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-02-11 Thread Andreas Sturmlechner
asturmlechner added a subscriber: apol. asturmlechner added a comment. It seems to me there was no change to these files since they were imported into this reporitory with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c , so

  1   2   3   4   5   6   7   >