[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

cfeck added a comment. Using that argument, we would have to remove the 'reveal password' option from KPasswordDialog, too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL PREFERENCES

[Differential] [Accepted] D3478: Port away from KDELibs4Support

cfeck accepted this revision. cfeck added a reviewer: cfeck. This revision is now accepted and ready to land. REPOSITORY rKGAMMA KGamma BRANCH master REVISION DETAIL https://phabricator.kde.org/D3478 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3370: KillWindow support for Wayland windows

cfeck added a comment. 5 seconds seems long in the face of a user. But if the application does actually handle the termination signal, and needs more than 5 seconds for cleanup, does it mean the cleanup procedure will be interrupted/aborted, or is only the GUI connection disconnected?

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

cfeck added a comment. monthly ping: What is the status of this? Ony unresolved issues? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3344: Remove deprecated --shut-up start flag

cfeck added a comment. Looking at main.cpp of plasmashell this option is indeed no longer used. (Some other options are also no longer used, so they should also be marked as deprecated, but I guess that's material for a new patch). REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D3323: Make it possible for plasmashell to log into kscreen.log

cfeck added a comment. Sorry, my fault. I was completely unaware that Plasma does not even use kscreen. Now that I have seen how it works, I am no longer disappointed to not find Plasma steps in the kscreen logs. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D3319: Load screenpool at the same time as we connect to screenchanged signals

cfeck added inline comments. INLINE COMMENTS > screenpool.cpp:37 > +{ > +m_primaryConnector; > +m_connectorForId.clear(); This line does nothing. What was the intention? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3319 EMAIL

[Differential] [Commented On] D3319: Load screenpool at the same time as we connect to screenchanged signals

cfeck added a comment. I confirm it fixes my issue (bug 366187), both with removed plasma* config files, as well as with my actual config files. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3319 EMAIL PREFERENCES

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

cfeck added a comment. The m_engine member is only available, when it uses the qalculate library instead of QScriptEngine. Please add the missing #ifdef ENABLE_QALCULATE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL

[Differential] [Commented On] D1944: Make NetworkManagerQt and BluezQt optional

cfeck added a comment. In https://phabricator.kde.org/D1944#35824, @broulik wrote: > We already have a feature and dependency freeze in place. This should not have gone into the Plasma/5.7 branch! This patch does not add any dependencies (or raises their minimum version).