[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. The patch has been merged: http://code.qt.io/cgit/qt/qtbase.git/commit/?h=dev&id=34f82b8abcb279542b6350e70609c549e39caafb I'll get back to this review once Qt 5.9 is released... REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Commented On] D3870: [Converter Runner] Also convert to the user's local currency

elvisangelaccio added a comment. In https://phabricator.kde.org/D3870#72454, @subdiff wrote: > In https://phabricator.kde.org/D3870#72396, @davidedmundson wrote: > > > (Slightly offtopic: > > when Martin G, eike or I make a diff, there's always an option to expand the context in ph

[Differential] [Commented On] D3714: Enable blurBehind effect if the window hints for it

elvisangelaccio added inline comments. INLINE COMMENTS > graesslin wrote in kwaylandintegration.cpp:35 > just wondering: we once have here a QByteArray and once a const char[] - > shouldn't we use the same in both? I used char[] for consistency with the old code, but I can use QByteArray if yo

[Differential] [Request, 11 lines] D3714: Enable blurBehind effect if the window hints for it

elvisangelaccio created this revision. elvisangelaccio added a reviewer: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed in https://git.reviewboard.kde.org/r/129648/ we cannot use KWindowEffects f

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

elvisangelaccio added a comment. So it seems that moving `desktop://` creates more problems than it solves. Maybe we should leave it in plasma? That would also solve the co-installability problem. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kd

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.30

elvisangelaccio added inline comments. INLINE COMMENTS > bshah wrote in CMakeLists.txt:8 > You can't do this, framework version is bumped by release script > automatically, so when you push this there is no 5.30.0 version of KIO. Which > will make it fail, you need to bump version once framewor

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.30

elvisangelaccio updated the summary for this revision. REPOSITORY R120 Plasma Workspace BRANCH drop-slaves REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, davidedmundson, #plasma Cc: l

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

elvisangelaccio added a comment. In https://phabricator.kde.org/D3530#65685, @davidedmundson wrote: > Would it be possible to make the version in frameworks co-installable with plasma? > > As long as the .protocol file still says protocol=desktop, dolphin and Plasma won't care what t

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.30

elvisangelaccio retitled this revision from "Drop kioslave folder, will be in KIO 5.29" to "Drop kioslave folder, will be in KIO 5.30". elvisangelaccio updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES

[Differential] [Updated, 2,133 lines] D3531: Drop kioslave folder, will be in KIO 5.29

elvisangelaccio updated this revision to Diff 8573. elvisangelaccio added a comment. - Bump minimum version, 5.29 is too close REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3531?vs=8572&id=8573 BRANCH drop-slaves REVISION DETAIL https://phab

[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

elvisangelaccio added a comment. In https://phabricator.kde.org/D3531#65681, @davidedmundson wrote: > 5.29 is in only a few days, that's way too close for a change this massive. > Especially one that requires a lot of distribution co-ordination as we're creating installation conflicts

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

elvisangelaccio added a dependent revision: D3531: Drop kioslave folder, will be in KIO 5.29. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: plasma-devel,

[Differential] [Request, 2,133 lines] D3531: Drop kioslave folder, will be in KIO 5.29

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed on plasma-devel. See https://phabricator.kde.org/D3530 This bumps the minim

[Differential] [Updated] D3531: Drop kioslave folder, will be in KIO 5.29

elvisangelaccio added a dependency: D3530: Import plasma-workspace kioslaves. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, le

[Differential] [Request, 2,130 lines] D3530: Import plasma-workspace kioslaves

elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed on plasma-devel, this patch imports the kioslaves from plasm

[Differential] [Closed] D3459: Add top_left_arrow cursor symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZE6316df30a995: Add top_left_arrow cursor symlinks (authored by elvisangelaccio). REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3459?vs=8412&id=8442 REVISION DE

[Differential] [Updated] D3459: Add top_left_arrow cursor symlinks

elvisangelaccio updated the test plan for this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3459 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensr

[Differential] [Updated] D3459: Add top_left_arrow cursor symlinks

elvisangelaccio updated the summary for this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3459 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreu

[Differential] [Request, 2 lines] D3459: Add top_left_arrow cursor symlinks

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Some mono apps (e.g. Keepass) look for a `top_left_arrow` cursor file instead of the usual

[Differential] [Closed] D3294: [kioslave/desktop] Port away from kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEf81c843dcfb3: [kioslave/desktop] Port away from kdelibs4support (authored by elvisangelaccio). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

[Differential] [Closed] D3293: [kioslave/applications] Port away from kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE9e0839aebfed: [kioslave/applications] Port away from kdelibs4support (authored by elvisangelaccio). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Request, 68 lines] D3294: [kioslave/desktop] Port away from kdelibs4support

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY All the targets now builds without linking to kdelibs4support TEST PLAN - desktop:// still

[Differential] [Updated] D3294: [kioslave/desktop] Port away from kdelibs4support

elvisangelaccio updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3294 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai, a

[Differential] [Request, 12 lines] D3293: [kioslave/applications] Port away from kdelibs4support

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The slave now builds without linking to kdelibs4support TEST PLAN applications:// still wo

[Differential] [Closed] D3243: [kioslave/remote] Port away from kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE72e39f083a10: [kioslave/remote] Port away from kdelibs4support (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3243?vs=7853&id=7890#toc REPOSITORY rP

[Differential] [Request, 241 lines] D3243: [kioslave/remote] Port away from kdelibs4support

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The `remote:/` kioslave now builds without kdelibs4support. The second commit also removes

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. In https://phabricator.kde.org/D2365#45684, @dfaure wrote: > The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some sel

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. In https://phabricator.kde.org/D2365#45684, @dfaure wrote: > The thing is, mimetype filters should be preferred above name filters. So the bug is in QFileDialog::selectMimeTypeFilter which "falls back" to selectNameFilter. Instead it should call some sel

[Differential] [Commented On] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. Ping? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, graesslin Cc: pl

[Differential] [Updated] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio added a comment. I think I figured out what's going on. This seems to be a regression introduced by https://phabricator.kde.org/rPLASMAINTEGRATION25be75542f831863e905b590b6429127df1b13d3. If I revert this commit, this test passes. So, this is what's happening. In this ex

[Differential] [Request, 53 lines] D2365: Add failing test case for selected filter from mimetype

elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, graesslin. elvisangelaccio set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. elvisangelaccio added a project: Plasma. Restricted Application added a subscriber: plasm

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in kdeplatformfiledialoghelper.cpp:78 > Can you explain and document here what this function does, i.e. input args > and return value? It's a bit confusing. > > "kde" is a mimetype name, e.g. application/zip right? > "list" i

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added a comment. Ping? I've been testing `QFileDialog` on Gnome shell and this issue cannot be reproduced there. So we should definitely fix in Plasma. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added a comment. Ping? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: mart, plasma

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added a comment. In https://phabricator.kde.org/D1813#33780, @elvisangelaccio wrote: > kde2QtFilter() is now more readable and we loop over the filter list only once. Ping? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Updated, 36 lines] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio updated this revision to Diff 4338. elvisangelaccio added a comment. kde2QtFilter() is now more readable and we loop over the filter list only once. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.o

[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio added a comment. In https://phabricator.kde.org/D1813#33652, @mart wrote: > shouldn't be kde2QtFilter() fixed instead? I guess I can try, but I'm not sure what exactly the function does... Btw this is the commit where it was introduced: https://github.com/KDE/kde

[Differential] [Request, 25 lines] D1813: Fix selected name filter with multiple mimetypes

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. elvisangelaccio added a subscriber: Plasma. elvisangelaccio set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. elvisangelaccio added a project: Plasma. Restricted App

[Differential] [Closed] D1663: [componentchooser email KCM] Improve text of tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP35896374895d: [kcm/componentchooser] Improve text of tooltip (authored by elvisangelaccio). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Request, 2 lines] D1663: [componentchooser email KCM] Improve text of tooltip

elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. elvisangelaccio added a subscriber: Plasma. elvisangelaccio set the repository for this revision to rPLASMADESKTOP Plasma Desktop. elvisangelaccio added a project: Plasma. Restricted Application added a subscriber: pl