[Differential] [Commented On] D3531: Drop kioslave folder, will be in KIO 5.29

lbeltrame added a comment. Speaking as a distro person: this might cause issues. The reason is that *if* we update to KF 5.29 (or 30) with this and Plasma stays as a stable version, we will get interesting conflicts. And of course, removing this in a stable version is **not** an option.

[Differential] [Commented On] D3249: Use our tooling for installing plasmoids

lbeltrame added a comment. The reason is that CMake doesn't generate the `konsoleprofiles` directory when configuring. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3249 EMAIL PREFERENCES

[Differential] [Commented On] D3249: Use our tooling for installing plasmoids

lbeltrame added a comment. Forgot to add, cmake complains about not being able to find plugin metadata. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3249 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Updated] D3249: Use our tooling for installing plasmoids

lbeltrame added a comment. kdeplasma-addons doesn't build here with these changes: [ 201s] [ 1%] Generating konsoleprofiles/package-metadata.json [ 201s] make[2]: Entering directory

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

lbeltrame added a comment. F354981: Spectacle.aq5462.png And this is a screenshot. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

lbeltrame added a comment. I've seen this on both multi and single screen. FV placed on the desktop, BTW. Screenshot coming up soon (because I run with the patch reverted). BRANCH master REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES

[Differential] [Commented On] D2932: Move availableScreenRect/Region up to AppletInterface.

lbeltrame added a comment. This breaks Folder View in a spectacular way: icons overflow out of the applet, and even the title is displayed out of the frame. In some situations I've also seen icons "dancing" continuously (but always overflowing). Reverting this commit fixes the issue

[Differential] [Closed] D2732: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE629fa121be72: [MPRIS Dataengine] Use UTF-8 for URLs instead of Latin1 (authored by lbeltrame). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2218: New logic for screen numbers in plasmashell

lbeltrame added a comment. In https://phabricator.kde.org/D2218#41975, @mart wrote: > most comments should be adressed now, will need again a period of test with several multiscreen users, as it has changed a bit I've been running this for a while, in two setups (one with 3

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. So far, no bad side effects that I can tell, even with the newer version. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, #plasma Cc:

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. I've been using this all week without ill side effects. In fact, this solves an issue I had when testing notmart's p-w branch. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. For now I didnt notice any problems (with version 1 of the patch), at least no regressions (notice that I wasn't able to reproduce the issue described in the bug since a long time). Is there any difference worth testing in the new revision? REPOSITORY

[Differential] [Commented On] D2156: improve output identification

lbeltrame added a comment. I have two identical screens set up as part of my 3 monitor set. I can test this. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D2156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas,

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

lbeltrame accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin, #plasma, davidedmundson, lbeltrame Cc: lbeltrame,

[Diffusion] [Updated] rBREEZEGTK93eb6e6ebcb8: Properly install GTK+ theme depending on version

lbeltrame added a subscriber: plasma-devel. lbeltrame added a comment. Added as of https://phabricator.kde.org/rBREEZEGTK4fcde887a817e948c1605d42091ca11504367f43. But seriously, why didn't this come up in the initial review? Like the libtaskmanager patch, did anyone try to actually

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Tested it on a single screen system. No issues with context menus. Notice: I don't see jump lists with the new task manager, should I see them? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1724 EMAIL PREFERENCES

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Second multiscreen issue found: right clicking to get the menu from a task gets the task in the wrong screen. Screenshot attached. F142172: Screenshot_20160603_190335.png It's also wrong for tasks in the same screen:

[Differential] [Commented On] D1724: Import Task Manager widgets ports to the new library.

lbeltrame added a comment. Tested with multiscreen, and found a bug already. ;) Not sure if it's in libtm or in the applets: but if you move a window to another screen, the corresponding task will not get updated until I minimize the task. IOW: - 2 task managers, one in screen 1,

[Differential] [Requested Changes To] D1722: Import next-gen libtaskmanager.

lbeltrame requested changes to this revision. lbeltrame added a reviewer: lbeltrame. lbeltrame added a comment. This revision now requires changes to proceed. --- libtaskmanager/taskgroupingproxymodel.cpp.orig 2016-06-03 14:45:46.798676712 +0200 +++

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

lbeltrame added a comment. Doesn't build here (posted to https://phabricator.kde.org/D1722 by mistake):

[Differential] [Updated] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.

lbeltrame added a comment. Doesn't build here: /home/abuild/rpmbuild/BUILD/plasma-workspace-5.6.90git~20160602T115930~https://phabricator.kde.org/rPLASMAWORKSPACE0d0c4f4a2247e8213deb232d2d80f12480dc05aa/libtaskmanager/taskgroupingproxymodel.cpp:40:19: error: field 'blacklistedAppIds'

[Differential] [Updated] D1744: Fix the ignore struts multi-screen handling

lbeltrame added a comment. +1 on the idea, although I won't be able to test until Monday. If anyone else can, that'd be great. ;) REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1744 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/