D29203: kirigami.pri: Add missing includes

patrickelectric closed this revision. patrickelectric added a comment. Merged. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203 To: patrickelectric, apol, mart, cblack, ognarb Cc: ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D29202: Remove unused QtConcurrent from colorutils

This revision was automatically updated to reflect the committed changes. Closed by commit R169:061a750068a4: Remove unused QtConcurrent from colorutils (authored by patrickelectric). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81262=81278

D29202: Remove unused QtConcurrent from colorutils

patrickelectric updated this revision to Diff 81262. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81260=81262 REVISION DETAIL https://phabricator.kde.org/D29202 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt src/colorutils.cpp To: patrickelectric, apol, mart Cc:

D29202: Remove unused QtConcurrent from colorutils

patrickelectric added a comment. @apol done. REVISION DETAIL https://phabricator.kde.org/D29202 To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29202: Remove unused QtConcurrent from colorutils

patrickelectric updated this revision to Diff 81260. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29202?vs=81240=81260 REVISION DETAIL https://phabricator.kde.org/D29202 AFFECTED FILES src/colorutils.cpp To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2,

D29202: Remove unused QtConcurrent from colorutils

patrickelectric added a comment. In D29202#657702 , @patrickelectric wrote: > In D29202#657700 , @apol wrote: > > > Then remove it from CMakeLists.txt as well? > > > Can you point what exactly

D29202: Remove unused QtConcurrent from colorutils

patrickelectric added a comment. In D29202#657700 , @apol wrote: > Then remove it from CMakeLists.txt as well? Can you point what exactly should be removed ? REPOSITORY R169 Kirigami REVISION DETAIL

D29202: Remove unused QtConcurrent from colorutils

patrickelectric added a comment. It fails to build when QtConcurrent can't be found. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202 To: patrickelectric, apol, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D29203: kirigami.pri: Add missing includes

patrickelectric created this revision. patrickelectric added reviewers: apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29203

D29202: Remove unused QtConcurrent from colorutils

patrickelectric created this revision. patrickelectric added reviewers: apol, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29202

D19166: Add application path as valid path for debuggers

This revision was automatically updated to reflect the committed changes. Closed by commit R871:8c74d90e28fb: Add application path as valid path for debuggers (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=54345=54412

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 54345. patrickelectric added a comment. Update style again REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=54316=54345 BRANCH arcpatch-D19166 REVISION DETAIL https://phabricator.kde.org/D19166

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 54316. patrickelectric added a comment. Update style REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=52099=54316 BRANCH arcpatch-D19166 REVISION DETAIL https://phabricator.kde.org/D19166

D19166: Add application path as valid path for debuggers

patrickelectric updated this revision to Diff 52099. patrickelectric added a comment.  - Add application path as valid path for debuggers REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19166?vs=52098=52099 BRANCH update_path REVISION DETAIL

D19166: Add application path as valid path for debuggers

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH update_path REVISION DETAIL

D18859: cdb: First working version

This revision was automatically updated to reflect the committed changes. patrickelectric marked 2 inline comments as done. Closed by commit R871:a32ec5e298a4: cdb: First working version (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D18859: cdb: First working version

patrickelectric updated this revision to Diff 51750. patrickelectric added a comment. Add missing override REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51518=51750 BRANCH arcpatch-D18859 REVISION DETAIL https://phabricator.kde.org/D18859

D18859: cdb: First working version

patrickelectric marked 2 inline comments as done. patrickelectric added a comment. Make tomaz happy REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen,

D18859: cdb: First working version

patrickelectric updated this revision to Diff 51518. patrickelectric added a comment. remove virtual, override. REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51516=51518 BRANCH cdb REVISION DETAIL https://phabricator.kde.org/D18859

D18859: cdb: First working version

patrickelectric added a comment. This is a screenshot of drkonqi on windows, it was built with craft and integrated with a WIP project. F6611293: image.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To:

D18859: [WIP] msvc: First commit

patrickelectric updated this revision to Diff 51516. patrickelectric added a comment. Correct and initial implementation REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51209=51516 BRANCH cdb REVISION DETAIL https://phabricator.kde.org/D18859

D18801: CMakeLists: Fix bfd.h include path on windows

This revision was automatically updated to reflect the committed changes. Closed by commit R871:3102b477d03d: CMakeLists: Fix bfd.h include path on windows (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51360=51361

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric updated this revision to Diff 51360. patrickelectric added a comment. Fix Tomaz REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51256=51360 BRANCH arcpatch-D18801 REVISION DETAIL https://phabricator.kde.org/D18801 AFFECTED

D18802: Fix pragma once problem with process class

This revision was automatically updated to reflect the committed changes. Closed by commit R871:e01d73c3c3be: Fix pragma once problem with process class (authored by patrickelectric). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18802?vs=51257=51358#toc REPOSITORY R871 DrKonqi

D18802: Fix pragma once problem with process class

patrickelectric added a comment. https://stackoverflow.com/questions/17107410/qt-field-has-incomplete-type REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh,

D18802: Fix pragma once problem with process class

patrickelectric added a comment. @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava,

D18802: Fix pragma once problem with process class

patrickelectric updated this revision to Diff 51257. patrickelectric added a comment. Update commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18802?vs=51068=51257 BRANCH arcpatch-D18802 REVISION DETAIL https://phabricator.kde.org/D18802

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric updated this revision to Diff 51256. patrickelectric added a comment. update commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51067=51256 BRANCH arcpatch-D18801 REVISION DETAIL https://phabricator.kde.org/D18801

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric added a comment. @mart commit message updated. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18801 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18859: msvc: First commit

patrickelectric added a comment. thank you @ngraham, but this is not ready to review yet. But be free to review @D18801 and @D18802 REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18859 To: patrickelectric Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18859: msvc: First commit

patrickelectric updated this revision to Diff 51209. patrickelectric added a comment. - msvc: Add cdb configuration REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18859?vs=51207=51209 BRANCH msvc REVISION DETAIL https://phabricator.kde.org/D18859

D18859: msvc: First commit

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH msvc REVISION DETAIL

D18802: Fix pragma once problem with process class

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH fix_pragma REVISION DETAIL

D18801: CMakeLists: Fix bgd.h include path on windows

patrickelectric updated this revision to Diff 51067. patrickelectric added a comment. Fix commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51066=51067 BRANCH fix_bfd REVISION DETAIL https://phabricator.kde.org/D18801 AFFECTED

D18801: CMakeLists: Fix bgd.h include path on windows

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH fix_bfd REVISION DETAIL

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. @rjvbb I got it to work here ! Took some time to figure out the problems with relative paths and KConfig, I am working to bundle kcrash in a .dmg :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces,

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file. CMake Error at src/CMakeLists.txt:84 (add_executable): Target "drkonqi" links to target "KF5::WindowSystem" but the target was not found. Perhaps a find_package()

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

This revision was automatically updated to reflect the committed changes. Closed by commit R871:515425143cb3: debugger: DataLocation is deprecated, move to AppDataLocation (authored by patrickelectric). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. After taking a second look on it, I was able to merge the patch from the `src`folder and not from the repository root folder, weird.. Will do the tests here and now ! REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb,

D4929: DrKonqi : lldb and Mac support

patrickelectric added a comment. Can you rebase it over the last master branch ? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk Cc: plasma-devel, #kde_applications, patrickelectric, kfunk, mart, broulik, kde-mac, ragreen,

D4929: DrKonqi : lldb support

patrickelectric added a comment. This revision now requires changes to proceed. What is the actual state of this patch ? REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces, kfunk Cc: patrickelectric, kfunk, mart, broulik, kde-mac, plasma-devel, ragreen, Pitel,

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric updated this revision to Diff 45831. patrickelectric added a comment. - debugger: Use c++11 for REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17024?vs=45830=45831 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17024

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric updated this revision to Diff 45830. patrickelectric added a comment. Typo REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17024?vs=45829=45830 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17024 AFFECTED FILES

D17024: debugger: DataLocation is deprecated, move to AppDataLocation

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira debugger: Use a stringlist to search in different paths for debugger

D7663: Correct text style

patrickelectric closed this revision. patrickelectric added a comment. Merged. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7663 To: patrickelectric, tcanabrava, mart, #kirigami Cc: plasma-devel, apol, mart, hein

D7663: Correct text style

patrickelectric added a reviewer: Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7663 To: patrickelectric, tcanabrava, mart, #kirigami Cc: plasma-devel, apol, mart, hein

D7663: Correct text style

patrickelectric created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Signed-off-by: Patrick José Pereira Update deploy information Signed-off-by: Patrick José