[Differential] [Closed] D3707: add simple test rig for service runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e21d625a937b: add simple test rig for service runner (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3707?vs=9164=9332#toc REPOSITORY R120 Plasma Workspace CHANGES

[Differential] [Updated, 214 lines] D3707: add simple test rig for service runner

sitter updated this revision to Diff 9164. sitter added a comment. switch to lgpl-2-3-ev as suggested in review REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3707?vs=9153=9164 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3707

[Differential] [Commented On] D3707: add simple test rig for service runner

sitter added inline comments. INLINE COMMENTS > dfaure wrote in servicerunnertest.cpp:59 > BTW if this is necessary then there's a bug in ksycoca :-) > > You can leave it (it helps getting the debug output from ksycoca in the right > method) but if it fails without this line, then please tell

[Differential] [Closed] D3704: ensure results are sorted by relevance

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7c00be121eeb: ensure results are sorted by relevance (authored by sitter). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3704?vs=9078=9154 REVISION DETAIL

[Differential] [Commented On] D3707: add simple test rig for service runner

sitter added inline comments. INLINE COMMENTS > dfaure wrote in servicerunnertest.cpp:5 > Is LGPL-v2-only on purpose here? Not particularly. It's the same as the existing source file though, to have the same license restrictions apply to both. Is it worth changing it to gpgl2+kdev considering

[Differential] [Updated, 214 lines] D3707: add simple test rig for service runner

sitter updated this revision to Diff 9153. sitter marked an inline comment as done. sitter added a comment. drop excessive code to isolate ksyscoca. setting qstandardpaths into testing mode is enough to isolate this {icon check-square} REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

[Differential] [Request, 235 lines] D3707: add simple test rig for service runner

sitter created this revision. sitter added reviewers: broulik, dfaure. sitter added subscribers: plasma-devel, dfaure. Restricted Application added a project: Plasma. REVISION SUMMARY - make sure that chrome apps have lower relevance than chrome itself - makes sure that konsole has higher

[Differential] [Closed] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b9ac84508645: do not explicitly check NotShownIn it's not necessary and incomplete (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D3705: do not explicitly check NotShownIn it's not necessary and incomplete

sitter created this revision. sitter added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KService::noDisplay() includes qualification for - NoDisplay entry itself - OnlyShowIn and NotShowIn

[Differential] [Updated, 6 lines] D3704: ensure results are sorted by relevance

sitter updated this revision to Diff 9078. sitter added a comment. remove cruft arc amended because I don't read (: REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3704?vs=9077=9078 BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Request, 24 lines] D3704: ensure results are sorted by relevance

sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY once we have built our actual final "raw-data" in the mapping hash, we iterate all runners and sort their

[Differential] [Closed] D3687: take matching logic out of match method and put it into a class

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8c7a95cc2cd7: take matching logic out of match method and put it into a class (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3687: take matching logic out of match method and put it into a class

sitter added inline comments. INLINE COMMENTS > broulik wrote in servicerunner.cpp:124 > isnt NotShowIn a list property? Doesn't KService have a getter for that or > even take that into account in noDisplay()? something to consider in a follow up, for now I'd like to get the refactor landed.

[Differential] [Request, 412 lines] D3687: take matching logic out of match method and put it into a class

sitter created this revision. sitter added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY refactor and qcdebug ::match was a super long spagetthi with multiple sub-matches. This was

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

sitter added a comment. Ok. Kindly take note of potential adjustment needs then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, plasma-devel Cc: graesslin,

[Differential] [Commented On] D3650: lower mouse acceleration limit to 0.0

sitter added a comment. Possibly. The KCM does not appear to actually work on wayland though ^^ if (!QX11Info::isPlatformX11()) { return; REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3650 EMAIL PREFERENCES

[Differential] [Closed] D3605: Revert "Do not ask for root permissions when it's unnecessary"

This revision was automatically updated to reflect the committed changes. Closed by commit R128:f2c69db182fb: Revert "Do not ask for root permissions when it's unnecessary" (authored by sitter). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D3650: lower mouse acceleration limit to 0.0

sitter created this revision. sitter added a reviewer: plasma-devel. sitter added a subscriber: jensreuterberg. Restricted Application added a project: Plasma. REVISION SUMMARY as seen in bug 95928 this used to be locked at 1 but was lowered to 0.1 as acceleration != speed, so <1 makes

[Differential] [Commented On] D3605: Revert "Do not ask for root permissions when it's unnecessary"

sitter added a comment. In https://phabricator.kde.org/D3605#67912, @davidedmundson wrote: > You've already done all the research which is 90% of the work, and now it's "just" a case of making sure m_infoToSave is always set for new users right? As I've mentioned I think this has

[Differential] [Request, 32 lines] D3605: Revert "Do not ask for root permissions when it's unnecessary"

sitter created this revision. sitter added reviewers: davidedmundson, mart. sitter added a subscriber: antlarr. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This reverts commit

[Differential] [Closed] D3454: properly parse exec line before qprocessing it for autostart

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE889be45e8934: properly parse exec line before qprocessing it for autostart (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 9 lines] D3454: properly parse exec line before qprocessing it for autostart

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY BUG: 372153 CHANGELOG: Repaired autostart of desktop files with place holders FIXED-IN: 5.8.4 TEST PLAN - add firefox.desktop to

[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

sitter added inline comments. INLINE COMMENTS > graesslin wrote in decoratedclientprivate.h:79 > @sitter with your distro hat on: what do you think works best? We have here a > public api with a "private" library which is used by KWin. Even if the API is public... plasma libs have no ABI

[Differential] [Commented On] D2930: purpose is a runtime dependency, do not conditional on it at build time

sitter added a comment. They have to package purpose since quickshare will have a broken runtime dependency (also spectacle is crippled without) :P REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2930 EMAIL PREFERENCES

[Differential] [Closed] D2930: purpose is a runtime dependency, do not conditional on it at build time

This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONS3242dd0280da: purpose is a runtime dependency, do not conditional on it at build time (authored by sitter). REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE

[Differential] [Updated, 4 lines] D2930: purpose is a runtime dependency, do not conditional on it at build time

sitter updated this revision to Diff 7081. sitter added a comment. drop excess change REPOSITORY rKDEPLASMAADDONS Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2930?vs=7080=7081 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2930 AFFECTED

[Differential] [Request, 6 lines] D2930: purpose is a runtime dependency, do not conditional on it at build time

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2930 AFFECTED FILES applets/CMakeLists.txt

[Differential] [Updated] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

sitter added a comment. seems to not be crashing anymore. unfortunately I can't comment on the correctness of the change REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 EMAIL PREFERENCES

[Differential] [Accepted] D2823: [Device Notifier] Only ever pop up if device is visible in the list

sitter accepted this revision. sitter added a comment. lgtm. and it works \o/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2823 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Closed] D2504: add a comment to get a summary in autogenerated appstream data

This revision was automatically updated to reflect the committed changes. Closed by commit rKINFOCENTERf7e4966ebd38: add a comment to get a summary in autogenerated appstream data (authored by sitter). REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D2504: add a comment to get a summary in autogenerated appstream data

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY summary is a required field in appstream data, without one we won't show up in appstream-based stores REPOSITORY rKINFOCENTER KInfoCenter

[Differential] [Closed] D2481: install new header

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE40e5ffbb357b: install new header (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2481?vs=6027=6070 REVISION

[Differential] [Request, 1 line] D2481: install new header

sitter created this revision. sitter added a reviewer: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it is included by concatenatetasksproxymodel.h (and probably others) REPOSITORY rPLASMAWORKSPACE

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter marked an inline comment as done. sitter added a comment. Dump from IRC > [12:18] ochurlaud: why is kcolorschemeeditor a standalone application if you don't use it as such? > [12:25] sitter: It can be used at such > [12:26] but you might want to access it from the colors

[Differential] [Closed] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP53b7f0d805a7: make kcolorschemeditor desktop entry spec compliant and refine it (authored by sitter). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter added a reviewer: ochurlaud. sitter added a subscriber: ochurlaud. sitter added a comment. Pulling in @ochurlaud The NoDisplay remark from Bhushan got me wondering how the KCM actually starts the app. And it turns out that it doesn't. SchemeEditorDialog* dialog = new

[Differential] [Request, 5 lines] D2478: make kcolorschemeditor desktop entry spec compliant and refine it

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY quoting the menu spec [1]: > Additional Categories should always be used in combination > with one of the Main Categories. So,

[Differential] [Closed] D2477: use RDN notiation for new desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP74a4e784feac: use RDN notiation for new desktop file (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2477?vs=6014=6018#toc REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Request, 60 lines] D2477: use RDN notiation for new desktop file

sitter created this revision. sitter added reviewers: graesslin, ochurlaud. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY needed to have window-app mapping work on wayland IIRC REPOSITORY rPLASMADESKTOP Plasma

[Differential] [Closed] D2377: use the feature summary to communicate runtime deps

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONf1191def10a0: use the feature summary to communicate runtime deps (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2377?vs=5754=5764#toc REPOSITORY

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

sitter added a comment. In https://phabricator.kde.org/D2377#44513, @heikobecker wrote: > Also imagine a user investigating why the two packages don't show up although he has installed them. In the landing version I have added notes about them not being detected automatically

[Differential] [Commented On] D2377: use the feature summary to communicate runtime deps

sitter added a comment. In https://phabricator.kde.org/D2377#44484, @heikobecker wrote: > So I think two Find... modules are also needed or "message..." should stay. Well. No. https://cmake.org/cmake/help/v3.0/command/find_package.html > Every non-REQUIRED find_package

[Differential] [Request, 15 lines] D2377: use the feature summary to communicate runtime deps

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN - cmake - prints warning - can be overridden with CMAKE_DISABLE_FIND_PACKAGE_foo REPOSITORY rPLASMAINTEGRATION Integration for Qt applications

[Differential] [Accepted] D2351: Remove sddm theme from look and feel

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. fix it then ship it INLINE COMMENTS > README.txt:8 > > For testing, I recommend symlinking ../components into components > When testing, don't wonder about the white space left of the

[Differential] [Closed] D2299: split load into two methods to improve readability a tad

This revision was automatically updated to reflect the committed changes. Closed by commit rKINFOCENTER91eea43b2a83: split load into two methods to improve readability a tad (authored by sitter). REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2300: always load about-distro in ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rKINFOCENTER8600dff7216c: always load about-distro in ctor (authored by sitter). REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2300?vs=5524=5525 REVISION

[Differential] [Updated] D2300: always load about-distro in ctor

sitter retitled this revision from "Update version number for 5.7.0 GIT_SILENT" to "always load about-distro in ctor". sitter updated the summary for this revision. REPOSITORY rKINFOCENTER KInfoCenter REVISION DETAIL https://phabricator.kde.org/D2300 EMAIL PREFERENCES

[Differential] [Updated, 6 lines] D2300: Update version number for 5.7.0 GIT_SILENT

sitter updated this revision to Diff 5524. sitter removed a reviewer: sebas. sitter added a comment. This revision now requires review to proceed. diff against right branch REPOSITORY rKINFOCENTER KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2300?vs=5523=5524

[Differential] [Request, 15 lines] D2300: Update version number for 5.7.0 GIT_SILENT

sitter created this revision. sitter added a reviewer: cfeck. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the

[Differential] [Request, 29 lines] D2299: split load into two methods to improve readability a tad

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY the two are fairly distinct and only make it harder to spot what happens where REPOSITORY rKINFOCENTER KInfoCenter BRANCH split-load

[Differential] [Closed] D2118: add neon mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6c3ca3d71e92: add neon mapping (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2118?vs=5017=5019 REVISION

[Differential] [Request, 2 lines] D2118: add neon mapping

sitter created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add neon mapping to bug report dialog (why is that stuff not queried from server? :|) REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH

[Differential] [Changed Subscribers] D2118: add neon mapping

sitter added a subscriber: Neon. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2118 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter Cc: #neon, plasma-devel, jensreuterberg, abetts, sebas

[Differential] [Closed] D2080: do not 'default' handle switch-cases

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENb484e6d6bf27: do not 'default' handle switch-cases (authored by sitter). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2080?vs=4927=4935 REVISION DETAIL

[Differential] [Closed] D2081: handle DVI

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENab629a30c398: handle DVI (authored by sitter). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2081?vs=4930=4936 REVISION DETAIL

[Differential] [Request, 2 lines] D2081: handle DVI

sitter created this revision. sitter added a reviewer: sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKSCREEN KScreen BRANCH Plasma/5.7-handle-dvi REVISION DETAIL https://phabricator.kde.org/D2081 AFFECTED FILES

[Differential] [Request, 9 lines] D2080: do not 'default' handle switch-cases

sitter created this revision. sitter added a reviewer: sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY using the default keyword hides compiler warnings. this causes enum expansion to require a dev to remember to

[Differential] [Accepted] D2060: [Device Notifier] Add shortcut to auto-mount settings

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2060 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Updated] D2044: WIP: [KSMServer] Load logout dialog after startup rather than on-demand

sitter added a comment. In https://phabricator.kde.org/D2044#37756, @broulik wrote: > Harald, weren't you even looking into offline updates? Yes. The thing is, we can't really force distributions to adopt offline updates as currently the only implementation I have seen is in

[Differential] [Updated] D1916: [Task Manager ToolTipDelegate] Match DesktopEntry for associating window/launcher with player

sitter added a comment. This should fix https://bugs.kde.org/show_bug.cgi?id=361965 if I am not mistaken. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1916 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D1797: drop useless shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASDKaaf1d41507e4: drop useless shebang (authored by sitter). REPOSITORY rPLASMASDK Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1797?vs=4289=4293 REVISION DETAIL

[Differential] [Request, 1 line] D1797: drop useless shebang

sitter created this revision. sitter added a reviewer: sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - makes no sense unless we install +x - don't need to install +x because desktops handle .desktop file

[Differential] [Closed] D1787: install config-X11 as it is used in task.h

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE1a39a51e2e36: install config-X11 as it is used in task.h (authored by Debian/Kubuntu Qt/KDE Maintainers , committed by sitter). REPOSITORY

[Differential] [Request, 5 lines] D1787: install config-X11 as it is used in task.h

sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1787 AFFECTED

[Differential] [Closed] D1785: libtaskmanager: bump soversion from 5 to 6

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE467ab9f30063: libtaskmanager: bump soversion from 5 to 6 (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 2 lines] D1785: libtaskmanager: bump soversion from 5 to 6

sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY new library features new ABI REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

[Differential] [Commented On] D1659: Remove pointless layout

sitter added a comment. Fixes infinite loop REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1659 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: sitter, plasma-devel, sebas

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a comment. Thanks! :) REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: mart, plasma-devel, sebas

[Differential] [Abandoned] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter abandoned this revision. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: mart, plasma-devel, sebas

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a comment. Neon presently only integrates source changes once a day. You should be able to poke rebuilds yourself btw as login is driven through phabricator http://build.neon.kde.org/job/xenial_unstable_frameworks_kservice/

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a comment. alas, doesn't seem to work http://build.neon.kde.org/job/xenial_unstable_plasma_kde-cli-tools_adt/3/console REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES

[Differential] [Closed] D1607: add highlevel test for icon theming

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONab33cf847ad5: add highlevel test for icon theming (authored by sitter). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Request, 8 lines] D1607: add highlevel test for icon theming

sitter created this revision. sitter added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY we expect kicontheme to have our theme as current theme REPOSITORY rPLASMAINTEGRATION Integration for Qt

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a comment. I honestly did not understand why the relevant function in kservice doesn't kdirwatch the path regardless of whether it exists. It seems like an incredibly silly thing to not do that, so I was thinking it was intentional :/ That said, I think simply removing the

[Differential] [Updated] D1603: change spinner from static images to in-cpu rotation

sitter marked an inline comment as done. INLINE COMMENTS breeze/breeze.script:125 fwiw, indentation is all over the place in this file. as of late I am thinking 2 spaces works best for the language though. REVISION DETAIL https://phabricator.kde.org/D1603 EMAIL PREFERENCES

[Differential] [Closed] D1603: change spinner from static images to in-cpu rotation

sitter closed this revision. REVISION DETAIL https://phabricator.kde.org/D1603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, broulik Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org

[Differential] [Updated] D1603: change spinner from static images to in-cpu rotation

sitter added a reviewer: broulik. REVISION DETAIL https://phabricator.kde.org/D1603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, broulik Cc: plasma-devel ___ Plasma-devel mailing list

[Differential] [Request, 51 lines] D1603: change spinner from static images to in-cpu rotation

sitter created this revision. sitter added a subscriber: plasma-devel. REVISION SUMMARY performance impact should be negligible eitherway and rotation does certainly make for the smoothest result. - uses a reference image that remains unchanged to rotate from. continued rotation of the

[Differential] [Changed Subscribers] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

sitter added a subscriber: plasma-devel. sitter added a project: Plasma. REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: plasma-devel, sebas

[Differential] [Updated] D1549: allow distro version number to be overridden in config file

sitter added a comment. very lovely REPOSITORY rKINFOCENTER KInfoCenter REVISION DETAIL https://phabricator.kde.org/D1549 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, sitter Cc: plasma-devel, sebas

[Differential] [Closed] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe0f2adaad6bc: expand window->desktopentry mapping heuristics to attempt RDN matching (authored by sitter). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 32 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter updated this revision to Diff 3424. sitter added a comment. improve comment a bit more. previous comment didn't really explain why more than one match can appear REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1447?vs=3423=3424

[Differential] [Updated, 30 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter updated this revision to Diff 3423. sitter added a comment. refine documentation REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1447?vs=3422=3423 BRANCH fix/taskmanager-rdn-lookup REVISION DETAIL

[Differential] [Request, 19 lines] D1447: expand window->desktopentry mapping heuristics to attempt RDN matching

sitter created this revision. sitter added a reviewer: hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When no match can be made from classClass, attempt a fallback where we match any DesktopEntryName that

[Differential] [Closed] D1143: do not install development helper files via cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rBREEZEGTK673f3e18af95: do not install development helper files via cmake (authored by sitter). REPOSITORY rBREEZEGTK Breeze for Gtk CHANGES SINCE LAST UPDATE

[Differential] [Request, 20 lines] D1143: do not install development helper files via cmake

sitter created this revision. sitter added a subscriber: plasma-devel. Herald added a project: Plasma. REVISION SUMMARY they have no use in production environments and only consume resources for no good reason REPOSITORY rBREEZEGTK Breeze for Gtk BRANCH master REVISION DETAIL

[Differential] [Closed] D1037: fix build properly by adding the lib dir to the includes

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP35d718c20707: fix build properly by adding the lib dir to the includes (authored by sitter). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Request, 1 line] D1037: fix build properly by adding the lib dir to the includes

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY libkonq_export is included using pointy brackets, so we need the its directory in the compiler search paths REPOSITORY rPLASMADESKTOP