luebking added inline comments.
INLINE COMMENTS
> composite.h:242
> bool m_composeAtSwapCompletion;
> - bool m_firstFrame = true;
> + int m_frameCount = 0;
> + int m_maxFramesTestedForSafety = 30;
m_testedFrames or similar, "Frame Count" is too generic.
Alternatively, just use some "int m_freezeDectionFrames = 30;" and count them
down (so when < 1, you're done)
> platform.h:148
> + PostFrame,
> + PostLastFrame
> };
Have a PreFirstFrame still and make PostLastFrame PostLastGuardedFrame or
similar. ("Last frame" is right before kwin shuts down ;-)
> x11_platform.cpp:215
> + Q_ASSERT(m_openGLFreezeProtection == nullptr);
> m_openGLFreezeProtection = new QTimer;
> m_openGLFreezeProtection->setInterval(15000);
Why do you recreate it with every frame?
Only create it PreFirstFrame and delete it PostLastFrame (and inbeteween simply
restart the pointer PreFrame)
> x11_platform.cpp:224
> + auto group = KConfigGroup(kwinApp()->config(),
> "Compositing");
> + group.writeEntry(unsafeKey, true);
> + group.sync();
same goes for config writing
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin, plasma-devel, davidedmundson, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas
