[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

2017-01-02 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in iconitem.cpp:325 > This makes no sense. > You can't round it to icon sizes *after* scaling, it means the shorter size > is always just wrong. > > If we do merge this patch, you want: > >

[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

2017-01-01 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > iconitem.cpp:325 > +const QSize = > m_iconPixmap.size().scaled(actualContainerSize, Qt::KeepAspectRatio); > +return QSize(Units::roundToIconSize(paintedSize.width()), > Units::roundToIconSize(paintedSize.height())); > } This