[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > broulik wrote in main_wayland.cpp:449 > That dialog is a separate binary kwin_rules_dialog. Except for the virtual > keyboard and wayland debug console I don't think there are any user-facing > kwin-internal windows (that are real windows, not

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

broulik added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Ah, ok, I misunderstood that this will inherit by session since I thought > kwin start the script exit-with-session. > > But then I still have one minor concern, for any window that actually inside >

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > I don't understand the concern. The QT_IM_MODULE env variable set here in the > code only affects KWin. It is not passed to any other process. > > Setting QT_IM_MODULE env variables will still

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Specifically, I mean X11 app under Wayland. Since kwin_wayland will start the > session I wonder if it will be inherit by the whole desktop session. I don't understand the concern. The QT_IM_MODULE

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

xuetianweng added inline comments. INLINE COMMENTS > graesslin wrote in main_wayland.cpp:449 > > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > > method for Qt. > > That's totally fine in this case. It only affects KWin and KWin doesn't have > any text input

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > xuetianweng wrote in main_wayland.cpp:449 > Don't do this. Otherwise qtvirtualkeyboard will be the only usable input > method for Qt. > > IMHO for wayland there should be a wayland specific im module that talk to > input method via wl_text.

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

mart added a comment. +1 REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: mart, broulik, plasma-devel, sebas ___

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added inline comments. INLINE COMMENTS > broulik wrote in virtualkeyboard.cpp:291 > Perhaps set ImhSensitiveData | ImhHiddenText ? No those are already part of the contentHints() and already mapped. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

graesslin added a comment. F129735: Spectacle.lx1761.png Virtual keyboard with some test input in the various supported layouts REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES