graesslin added a comment.
In https://phabricator.kde.org/D1989#47207, @bdhruve wrote:
> Alright i will do the said things. And regarding the name, how does
KWinDeclarative sound to you?
It still doesn't describe what it is. Thinking about it, I would suggest a
name with
bdhruve added a comment.
In https://phabricator.kde.org/D1989#46775, @graesslin wrote:
> I would like to see this integrated. But I think a few things need to be
done:
>
> - I would love to see the example you had in your blog post added to tests
> - I'm still unhappy about the
graesslin added a comment.
I would like to see this integrated. But I think a few things need to be done:
- I would love to see the example you had in your blog post added to tests
- I'm still unhappy about the name KWinQml - it's just not saying what it is.
And actually it's not Qml
graesslin added inline comments.
INLINE COMMENTS
> kwinqml.cpp:153
> +if (m_seat != nullptr) {
> +m_seat->keyPressed(event->nativeScanCode() - 8);
> +}
only do that on X11, if we are on Wayland that would be wrong. So do something
like:
const int magicOffset =
bdhruve added a comment.
In https://phabricator.kde.org/D1989#44453, @graesslin wrote:
> I just remembered: on X11 one needs to subtract 8 from the key code...
The keyEvents are working perfectly now because of the solution you gave.
Thank you. :-)
Are there any other issues in
graesslin added a comment.
I just remembered: on X11 one needs to subtract 8 from the key code...
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1989
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, bshah, graesslin,
bdhruve added a comment.
In https://phabricator.kde.org/D1989#44333, @graesslin wrote:
> > - KeyPress events to send keys.
> >
> > However, keyevents are not working as it should, if i press 'a' it
types something different.
>
> might be that this is just not possible to send
graesslin added a comment.
> - KeyPress events to send keys.
>
> However, keyevents are not working as it should, if i press 'a' it types
something different.
might be that this is just not possible to send key events like that. In
general QKeyEvent delivers the keysym. That is
bdhruve added inline comments.
INLINE COMMENTS
> graesslin wrote in kwinqml.cpp:68
> ideally you don't need to repaint everything, but could just update the
> actual changed areas (carried in the damaged signal)
I am not much knowledgeable about how to render only specific area in QtQuick,
i
bshah added inline comments.
INLINE COMMENTS
> graesslin wrote in kwinqml.cpp:63
> don't use qDebug, please use categorized logging.
I'd say just remove this and debug statement below, they can get noisy, because
it will be triggered at every frame repaint.
> kwinqml.cpp:112-113
> +n
graesslin added a comment.
In https://phabricator.kde.org/D1989#39559, @bdhruve wrote:
> I am not getting how to proceed further now, can you please help me on
this? Also, current confusion i have is, should kwin_wayland nested window
appear when i run qmlscene? Because currently it
bdhruve added a comment.
In https://phabricator.kde.org/D1989#38998, @bdhruve wrote:
> In https://phabricator.kde.org/D1989#38844, @graesslin wrote:
>
> > Looks good now and I think we can look into the next steps: rendering the
KWin instance you launch. The launched KWin instance
bdhruve added a comment.
In https://phabricator.kde.org/D1989#38844, @graesslin wrote:
> Looks good now and I think we can look into the next steps: rendering the
KWin instance you launch. The launched KWin instance connects to your Wayland
server, binds to the Shell and will create a
graesslin added a comment.
Looks good now and I think we can look into the next steps: rendering the
KWin instance you launch. The launched KWin instance connects to your Wayland
server, binds to the Shell and will create a ShellSurface. That you will get
through a signal on m_shell -
graesslin added inline comments.
INLINE COMMENTS
> kwinqml.cpp:47-49
> +if (!m_socketName.isNull() && !m_socketName.isEmpty()) {
> +m_display->setSocketName(m_socketName);
> +}
actually we don't need that. The socketName is for the kwin process which we
start. Our Display in
graesslin added inline comments.
INLINE COMMENTS
> config-kwin.h.cmake:6
> #define KWIN_INTERNAL_NAME_X11 "${KWIN_INTERNAL_NAME_X11}"
> +#define KWIN_INTERNAL_NAME_WAYLAND "${KWIN_INTERNAL_NAME_WAYLAND}"
> #define KWIN_CONFIG "${KWIN_NAME}rc"
best generate the absolute install path of the
bdhruve added a comment.
In https://phabricator.kde.org/D1989#38023, @graesslin wrote:
> I would like to see a test case which verifies that it starts the
kwin_wayland instance and terminates it again.
I am not sure on how to add testcase for this?
Here is code I use for
bshah added a comment.
Some minor issues I noticed..
INLINE COMMENTS
> CMakeLists.txt:13
> + Qt5::Quick
> + KF5::WaylandClient
> + KF5::WaylandServer
Not required, you just use WaylandServer API.
> kwinplugin.h:1
> +#ifndef KWINPLUGIN_H
> +#define KWINPLUGIN_H
This and all other header
bdhruve added inline comments.
INLINE COMMENTS
> graesslin wrote in kwinqml.h:34
> instead of using start which needs to be invoked manually, you could also
> react on the initialization completed in the QQuickItem
I have fixed all other issues, but i am not sure on how to do this?
REPOSITORY
19 matches
Mail list logo
