sebas added a comment.
@davidedmundson Did you also get to try it?
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: davidedmundson, graesslin, lbeltrame,
lbeltrame added a comment.
So far, no bad side effects that I can tell, even with the newer version.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc:
lbeltrame added a comment.
I've been using this all week without ill side effects. In fact, this solves
an issue I had when testing notmart's p-w branch.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
sebas added a comment.
@davidedmundson Good point, I'll revert that one and will give it another
good round of testing. It'd be nice if you could test once you're back next
week (same for @lbeltrame, of course.)
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
davidedmundson added a comment.
> With this patch
>
> - we detect the case when multiple identical outputs are connected (same
hash)
> - each of the duplicate outputs also gets matched against the output name
OK, that makes sense.
But I think then you need to revert the
graesslin added inline comments.
INLINE COMMENTS
> sebas wrote in outputgrid_2x3.json:129
> What's the issue?
the "No newline at end of file". Just add a new line.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
sebas added inline comments.
INLINE COMMENTS
> graesslin wrote in outputgrid_2x3.json:129
> nitpick
What's the issue?
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas,
graesslin added a comment.
Looks good to me
INLINE COMMENTS
> outputgrid_2x3.json:129
> +]
> \ No newline at end of file
nitpick
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
lbeltrame added a comment.
For now I didnt notice any problems (with version 1 of the patch), at least
no regressions (notice that I wasn't able to reproduce the issue described in
the bug since a long time).
Is there any difference worth testing in the new revision?
REPOSITORY
sebas added a comment.
@lbeltrame Does it work for you?
If you can try this patch, that'd be awesome (also if it already works for
you, to check if the patch breaks anything).
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
sebas added a comment.
@davidedmundson Sure.
With this patch
- we detect the case when multiple identical outputs are connected (same hash)
- each of the duplicate outputs also gets matched against the output name
The problem I'm fixing is that currently (without my patch) the
graesslin added a comment.
asking the evil question ;-) Can we autotest this?
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas, #plasma
Cc: graesslin, lbeltrame,
lbeltrame added a comment.
I have two identical screens set up as part of my 3 monitor set. I can test
this.
REPOSITORY
rKSCREEN KScreen
REVISION DETAIL
https://phabricator.kde.org/D2156
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: sebas,
sebas added a comment.
I'd like to get some feedback on the approach, however. I think this is
actually a nice minimal fix, as we can't really change how the id is
generated. I may be missing something here.
This obviously needs some testing. It shouldn't break existing setups, but I
14 matches
Mail list logo
