[Differential] [Commented On] D2399: New new SDDM theme

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in UserDelegate.qml:85 > It's a bit more complex with the white frame that has to be transparent on > the inside. > > So that then needs to be drawn somehow. I guess making an SVG of a circle > would work. Using layers

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in KeyboardButton.qml:13 > is this domain valid for sddm as well? It was...though that broke when this folder was moved. Good spot. > mart wrote in UserDelegate.qml:85 > this version you have is probably is significantly faster

[Differential] [Commented On] D2399: New new SDDM theme

mart added inline comments. INLINE COMMENTS > KeyboardButton.qml:13 > > -text: instantiator.objectAt(currentIndex).shortName > +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout: > %1", instantiator.objectAt(currentIndex).shortName) > implicitWidth:

[Differential] [Commented On] D2399: New new SDDM theme

mart added a comment. In https://phabricator.kde.org/D2399#45044, @davidedmundson wrote: > Screenshot as requested. > > F255167: Spectacle.h20090.png > > Note the coloured icons for actions will be changing when Andreas pushes some change.

[Differential] [Commented On] D2399: New new SDDM theme

mart added a comment. In https://phabricator.kde.org/D2399#44873, @apol wrote: > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. but also working QML code, that means, it must be maintained. if there are volunteers, awesome, if it stays

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added a comment. Screenshot as requested. F255167: Spectacle.h20090.png Note the coloured icons for actions will be changing when Andreas pushes some change. Also I have some unresolved comments here:

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added a comment. In https://phabricator.kde.org/D2399#44873, @apol wrote: > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the old theme was already

[Differential] [Commented On] D2399: New new SDDM theme

apol added a comment. Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2399 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/