[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in scriptengine_v1.cpp:490 > I'm a bit lost. > > We have an argument to this method which is stored as local QString layout. > > The old code found all Plasma/LayoutTemplates with that name. > As far as I can tell, this finds

[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D2723#50572, @andreaska wrote: > the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel. good point, looking into that REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D2723: port panel loading away from ksycoca

2016-09-09 Thread andreaska (Andreas Kainz)
andreaska added a comment. the emtpy system tray (desktop right click add panel) shouldn't be a panel cause it doesn't work like a panel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2723 EMAIL PREFERENCES