[Differential] [Commented On] D2779: Port to Grid.

2016-09-14 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > main.qml:178 > > property int effectiveRows: { > +if (!pagerModel.count) { Looks like this should be readonly... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2779 EMAIL

[Differential] [Commented On] D2779: Port to Grid.

2016-09-14 Thread apol (Aleix Pol Gonzalez)
apol added a comment. It's often useful not to have the type on a variable's name so that patches like this don't need to happen. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2779 EMAIL PREFERENCES