graesslin added a comment.
> Any plan for including the same to oxygen ?
Yes, will do the same change for Oxygen now.
REPOSITORY
rBREEZE Breeze
BRANCH
kstyle-move-wayland
REVISION DETAIL
https://phabricator.kde.org/D3019
EMAIL PREFERENCES
https://phabricator.kde.org/settings/pa
graesslin added inline comments.
INLINE COMMENTS
> hpereiradacosta wrote in breezewindowmanager.cpp:264
> mmm. I know delta functions are handy, but isn't this one a tad complicated ?
> Personnally I find this code quite hard to read. (especially the sequence of
> closing }s and )s later on ...
graesslin added a comment.
In https://phabricator.kde.org/D3019#56891, @hpereiradacosta wrote:
> I'm using kwayland from git master. Are there some commits missing ?
yes, see the linked dependencies.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3019
hpereiradacosta added inline comments.
INLINE COMMENTS
> breezewindowmanager.cpp:264
> +[registry, this] {
> +const auto interface = registry->interface(
> Registry::Interface::Seat );
> +if( interface.name != 0 ) {
mmm. I know delta functions are han
sebas added a comment.
Looks good from my side. Let's have @hpereiradacosta have a look as well,
though.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3019
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma_o
