apol added a comment.
Other than that, LGTM. INLINE COMMENTS > passworddialog.cpp:65 > connect(verifyEdit, SIGNAL(textEdited(QString)), > SLOT(passwordChanged())); > + connect(buttons->button(QDialogButtonBox::Ok), SIGNAL(clicked(bool)), > this, SLOT(accept())); > + connect(buttons->button(QDialogButtonBox::Cancel), > SIGNAL(clicked(bool)), this, SLOT(reject())); It's better to use the dialog box directly, rather than accessing the buttons: connect(buttonBox, &QDialogButtonBox::accepted, dialog, &QDialog::accept); connect(buttonBox, &QDialogButtonBox::rejected, dialog, &QDialog::reject); REPOSITORY rUSERMANAGER User Manager REVISION DETAIL https://phabricator.kde.org/D3071 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidk, #plasma, mart Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
