[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-18 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > main.qml:47 > > +Plasmoid.shrinkOnReactivation: !isDash > + If you want this to be in Plasma/5.8.x we can't rely on this being available. Plasma 5.8.x *has* to still work with frameworks 5.26. You can either go master only or do

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-17 Thread subdiff (Roman Gilg)
subdiff added a comment. In https://phabricator.kde.org/D3079#57067, @davidedmundson wrote: > This breaks the normal keyboard shortcut working at all. > > You either need to connect to both or > > if we put in the addition emit I suggest in

[Differential] [Commented On] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

2016-10-17 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. This breaks the normal keyboard shortcut working at all. You either need to connect to both or if we put in the addition emit I suggest in https://git.reviewboard.kde.org/r/129204/ and then you don't need this change. REPOSITORY rPLASMADESKTOP