[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

ivan added inline comments. INLINE COMMENTS > broulik wrote in ContextMenu.qml:413 > Imho this should be a regular function() like the others I didn't want to pollute the outside world - it should be as efficient as if it was a regular function (if qt jit is sane - it could even be inlined). >

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

broulik added a comment. >> probably in that case there should be the simple "add launcher when not running" > > Yes, and adding to all activities would be the smartest choice I'd say. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3106

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

ivan added a comment. > probably in that case there should be the simple "add launcher when not running" Yes, and adding to all activities would be the smartest choice I'd say. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3106 EMAIL PREFEREN

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

broulik added a comment. What happens if there is only one activity? I don't use activities and I don't want a complicated submenu for pinning applications in this case. INLINE COMMENTS > ContextMenu.qml:413 > + > +var createNewItem = function(id, title, url, activities) { >

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

ivan added a comment. Preview: F369927: snap.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3106 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, mart