antlarr added a comment.
@hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit
for Plasma/5.8?
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3192
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr,
hpereiradacosta added a comment.
Hi,
I am fine with the commit (especially since it fixes a bug which I have had
no time to reproduce)
Now since indeed 2 more pixels are needed on top of the ones from the
MenuButton_IndicatorWidth, I would be inclided to just change
size.rwidth() +=
antlarr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in breezestyle.cpp:2507
> you're still basing the height off the MenuButton_IndicatorWidth which you're
> otherwise not using
>
> Is that intentional?
Good point, I didn't notice that it was using MenuButton_IndicatorWidth
