[Differential] [Commented On] D3603: Option to show percentage charge in the icon

2016-12-07 Thread mart (Marco Martin)
mart added a comment. F672027: Spectacle.T21326.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik,

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

2016-12-07 Thread broulik (Kai Uwe Broulik)
broulik added a comment. You forgot BadgeOverlay.qml INLINE COMMENTS > ConfigGeneral.qml:28 > + > +signal configurationChanged > + Unused > ConfigGeneral.qml:30-31 > + > +width: childrenRect.width > +height: childrenRect.height > +implicitWidth: pageColumn.implicitWidth

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

2016-12-05 Thread mart (Marco Martin)
mart added a comment. eew, sorry, that canvas thing was from an old experiment i did for a possible alternative graphics, which i forgot to kill ;) INLINE COMMENTS > broulik wrote in main.xml:11 > I think this could even be the default? not sure it's pretty enough for default (yet?), in

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

2016-12-05 Thread broulik (Kai Uwe Broulik)
broulik added a comment. Nifty. That I haven't thought of that kind of placement before. I always wanted some crappy overlay like we had before. Can you please check again with opacity mask instead of just overlaying a Rectangle. Also, what's up with the Canvas thing? INLINE COMMENTS