markg added a comment.
In https://phabricator.kde.org/D3738#87617, @subdiff wrote:
> In https://phabricator.kde.org/D3738#87601, @markg wrote:
>
> > ...
>
>
> There has already been a commit to master tackling this issue:
https://phabricator.kde.org/D4491
That's great,
subdiff added a comment.
In https://phabricator.kde.org/D3738#87601, @markg wrote:
> ...
There has already been a commit to master tackling this issue:
https://phabricator.kde.org/D4491
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL
broulik added a comment.
I like thew new layout a lot, it might let me keeping them enabled! :D Good
job.
Few nitpicks:
- Font color of the large heading in the tooltip is darker/stronger, I think
Heading (used in the default tooltip) sets some opacity making it softer
-
hein added a comment.
I'm against adding a config option for it for a while. We've had a lot of
user feedback that the old ones were too big and fluffy, which this is a
reaction to. And note that as Roman points out hidpi scaling is accounted for
(I use a 3000x200 13" screen myself). Let's
anthonyfieroni added a comment.
Maybe we can add configuration for tooltip size? I, personally, like very
much biggest ones.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
subdiff added a comment.
In https://phabricator.kde.org/D3738#74290, @hein wrote:
> I just tried running the patch, and instead of smooth morphs when going
between tooltip contents I get an instant change with a 1-frame glitchy stretch
... it's pretty bad.
Sorry, I can't
hein added a comment.
I just tried running the patch, and instead of smooth morphs when going
between tooltip contents I get an instant change with a 1-frame glitchy stretch
... it's pretty bad.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL
subdiff added inline comments.
INLINE COMMENTS
> hein wrote in ContextMenu.qml:59
> That's kinda what I was wondering. If the context menu is opened for an
> element in the tooltip, why is the visualParent the task item?
It's basically the second best solution. ;)
When I tried to set the
hein added inline comments.
INLINE COMMENTS
> subdiff wrote in ContextMenu.qml:59
> The context menu can be called now also for a grouped task. The visualParent
> is the grouped task parent though. So we need to get the modelProps of
> property var modelIndex (which is in case of a grouped
subdiff added a comment.
In https://phabricator.kde.org/D3738#70083, @colomar wrote:
> Great improvements!
> Is the desktop / Activity only shown if
>
> - there are multiple ones and
> - the task manager shows tasks from different ones?
Glad you like it! And yes, yes. :)
colomar added a comment.
Great improvements!
Is the desktop / Activity only shown if
- there are multiple ones and
- the task manager shows tasks from different ones?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3738
EMAIL PREFERENCES
11 matches
Mail list logo