davidedmundson added a comment.
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4214
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliez
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ListItem.qml:97
> > in fact it's what it was supposed to happen in the first place
>
> We have the highlight for the item under mouse.
> Why should the delegate change too?
If that's the case, then we should remove the opaci
davidedmundson added inline comments.
INLINE COMMENTS
> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
>
> It's barely a behavioral change, in fact it's what it was supposed to happen
> in the first place: give feedback on hover whe
davidedmundson added a comment.
Concept seems fine. New binding has some typos
INLINE COMMENTS
> ListItem.qml:97
> +prefix: (listItem.sectionDelegate ? "section" :
> +(background.pressed || listItem.checked ||
> listItem.containsMouse) ? "pressed" : "normal")
>
why
