[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-12 Thread Kai Uwe Broulik
broulik added a comment. `QCoreApplication::desktopFileName()` is the full desktop file name without the path, ie. as far as I can tell with the `.desktop` suffix, the Gnome spec explicitly says it should be sent without it, though. REPOSITORY R289 KNotifications REVISION DETAIL https:/

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-07 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D4416#83780, @cfeck wrote: > QApplication::desktopFileName() was only added in Qt 5.7, while frameworks still support Qt 5.6. Please add a Qt version check around the new code. Done, thanks REPOSITORY R289 KNotifica

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-07 Thread Christoph Feck
cfeck added a comment. QApplication::desktopFileName() was only added in Qt 5.7, while frameworks still support Qt 5.6. Please add a Qt version check around the new code. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES https://phabric

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-04 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4416#83019, @mck182 wrote: > In https://phabricator.kde.org/D4416#82951, @hein wrote: > > > Gnome-only spec? Why aren't they contributing to fd.o? > > > "Galago is dead, we took over, deal with it." > > https://bugzil

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-04 Thread Martin Klapetek
mck182 added a comment. In https://phabricator.kde.org/D4416#82951, @hein wrote: > Gnome-only spec? Why aren't they contributing to fd.o? "Galago is dead, we took over, deal with it." https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25 REPOSITORY R289 KNotifications BRAN

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-04 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D4416#82951, @hein wrote: > Gnome-only spec? Why aren't they contributing to fd.o? That's most certainly not the best forum to discuss this. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricato

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-03 Thread Eike Hein
hein added a comment. Gnome-only spec? Why aren't they contributing to fd.o? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, ap

[Differential] [Commented On] D4416: Send desktopfilename as part of notifyByPopup hints

2017-02-02 Thread Aleix Pol Gonzalez
apol added a comment. Same was done with the transient hint, btw. Maybe it would make sense to add a comment pointing to the documentation this refers to? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D4416 EMAIL PREFERENCES https://phabri