subdiff added a comment.
In https://phabricator.kde.org/D4491#90362, @anthonyfieroni wrote:
> At least i plan to commit it from tomorrow release, so title 1 line or 2
lines ?
After the pic
anthonyfieroni added a comment.
At least i plan to commit it from tomorrow release, so title 1 line or 2
lines ?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4491
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
anthonyfieroni added a comment.
> ! In https://phabricator.kde.org/D4491#90001, @jsalatas wrote:
> I like the idea but ElideMiddle doesn't seem to work for me: Seems that it
just keeps the left part of the text that it can fit and ignores anything else
:\
Yeah, looks like only
jsalatas added a comment.
In https://phabricator.kde.org/D4491#89982, @anthonyfieroni wrote:
> ElideMiddle on basic regex match for path
I like the idea but ElideMiddle doesn't seem to work for me: Seems that it
just keeps the left part of the text that it can fit and ignores
anthonyfieroni added inline comments.
INLINE COMMENTS
> jsalatas wrote in ToolTipInstance.qml:108
> Is it possible to have it always fixed to 2 lines and not just max to 2?
> Otherwise having either 1 or 2 line we would end up in unaligned/bad-looking
> tooltips (see screenshot), although I
markg added a comment.
In https://phabricator.kde.org/D4491#88362, @anthonyfieroni wrote:
> I must investigate why elide does not work, margins are a bit different
from others like systray, kicker, etc.
> I figure out it, maximumLineCount or height sould be setted, i unsetted
subdiff added a comment.
In https://phabricator.kde.org/D4491#84112, @anthonyfieroni wrote:
> In work i'm on 5.8 :) I don't know what you want to see in screenshot when
we talk to pixel density i.e. it depends on diagonal inches. I will update
patch with heading levels instead of labels
broulik added a comment.
> if "everywhere else" is flawed aswell in some way.
If it were consistently "flawed", it's better than *one* place where it's
blatantly different.
> these look fine, but only because there is no text next to them
There is? It's just that in Plasma's
anthonyfieroni added a comment.
In work i'm on 5.8 :) I don't know what you want to see in screenshot when we
talk to pixel density i.e. it depends on diagonal inches. I will update patch
with heading levels instead of labels and no magic numbers, later this night :)
REPOSITORY
R119
subdiff added a comment.
In https://phabricator.kde.org/D4491#84110, @broulik wrote:
> It doesn't *completely* change the look, it makes it consistent with
literally everywhere else ...
Then we have to ask ourselves if "everywhere else" is flawed aswell in some
way. For example
broulik added a comment.
It doesn't *completely* change the look, it makes it consistent with
literally everywhere else and this is not the first time the font size was
complained about, this needs to be fixed.
The only change I could see from your comparison screenshot is the top
subdiff added a comment.
Can you add screenshots on your 13.3 screen with and without this patch?
I know at the moment the code on master is not perfect. But we have to find a
solution, which doesn't change the current look of the text lines completely.
The Heading class to my taste has
12 matches
Mail list logo
