[Differential] [Commented On] D4606: don't show 0% when no battery

2017-02-15 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4606#86236, @broulik wrote: > the idea was to stilòl have the badge show up to not make that option look "broken". tough also having the checkbox greyed out makes sense too ah, found another reason why keeping the badge would

[Differential] [Commented On] D4606: don't show 0% when no battery

2017-02-15 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4606#86236, @broulik wrote: > Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option

[Differential] [Commented On] D4606: don't show 0% when no battery

2017-02-14 Thread Kai Uwe Broulik
broulik added a comment. Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option checked but then have it not do anything – maybe the check box