[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-22 Thread Kai Uwe Broulik
broulik added a comment. > Would it be possible to display the information together with the information of the current first tab? No. Also, currently I cannot tell the thing to exclude certain information (like file type and other info already shown on the first page). REPOSITORY

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-22 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D4614#88485, @fabianr wrote: > > A case could be made that this information is actually the most interesting one, and could have a more prominent place, then on the last tab. Would it be possible to display the

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-22 Thread Fabian Riethmayer
fabianr added a comment. The layout looks good and is according to the HIG. You probably shouldn't display duplicate information, but if I understood the comments correct this is already addressed. A case could be made that this information is actually the most interesting one, and

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-17 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in baloofilepropertiesplugin.desktop:8 > where does this list come from? I went through all extractors in KFileMetaData and looked at what they support. Unfortunately KPropertiesDialog does not support wildcards. But then,

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-16 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > Messages.sh:6 > + > +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml > | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot > rm -f rc.cpp This is obviously wrong, it would duplicate a lot of stuff that

[Differential] [Commented On] D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2017-02-16 Thread David Edmundson
davidedmundson added a comment. looks sensible. INLINE COMMENTS > Messages.sh:6 > + > +$XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h -o -name \*.qml > | grep -v "/src/filepropertiesplugin/"` -o $podir/baloowidgets.pot > rm -f rc.cpp is this not overwriting the generated