mart added a comment.
In https://phabricator.kde.org/D4797#90144, @broulik wrote:
> > So changing only the theme would mean to change the svg of `ButtonStyle`,
which is not desirable.
>
> Then we need to introduce new elements in `widgets/button.svg` or a new
`widget/toolbutton.svg`
mart added a comment.
In https://phabricator.kde.org/D4797#90142, @subdiff wrote:
> In https://phabricator.kde.org/D4797#90126, @broulik wrote:
>
> > Design looks ok but still you can't change `ToolButtonStyle`, instead,
the Breeze Plasma theme needs to be changed.
>
>
> Sorry,
broulik added a comment.
> So changing only the theme would mean to change the svg of `ButtonStyle`,
which is not desirable.
Then we need to introduce new elements in `widgets/button.svg` or a new
`widget/toolbutton.svg` for `ToolButton` which is used and falls back to the
old behavior
hpereiradacosta added a comment.
> Also I tested it now with the Oxygen and United themes, and `QToolButton`
has still the same flat frame line in highlight color around it in when hovered
like in Breeze, so it seems to be independent of the theme in `QToolButton` as
well. In the Oxygen case
subdiff added a comment.
In https://phabricator.kde.org/D4797#90126, @broulik wrote:
> Design looks ok but still you can't change `ToolButtonStyle`, instead, the
Breeze Plasma theme needs to be changed.
Sorry, I didn't quite get it the last time you mentioned it. I think I
unders
broulik added a comment.
Design looks ok but still you can't change `ToolButtonStyle`, instead, the
Breeze Plasma theme needs to be changed.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4797
EMAIL PREFERENCES
https://phabricator.kde.org/setti
hpereiradacosta added a comment.
+ 1 for me. Looks good!
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4797
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: subdiff, #plasma
Cc: ltoscano, broulik, hpereiradaco
broulik added a comment.
> Would you support the idea of using the KToolBar ToolButton design for the
QML ToolButton aswell?
Good idea.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4797
EMAIL PREFERENCES
https://phabricator.kde.org/setti
hpereiradacosta added a comment.
Hi Roman,
> Would you support the idea of using the KToolBar ToolButton design for the
QML ToolButton aswell? It looks way better in my opinion and it would make the
use of tool buttons more consistent.
Yes, I would support this. It would be more con
ltoscano added a comment.
In https://phabricator.kde.org/D4797#90068, @subdiff wrote:
> This looks weird, because painting a whole button is not a small hint for
the user that he can interact with the element but looks more like a completely
new independent button suddenly being created.
subdiff added a comment.
I see where you're coming from. You're right, that the rounded edges don't
fit so well to other Plasma element. So I would try to find another design,
because I still think the current ToolButton is ugly. Let me make it more
clear, what I dislike about the current (f
broulik added a comment.
I agree with Hugo. I also never liked the faint blue press effect of buttons
that was introduced in the Breeze revamp in 5.5 to begin with, having that as
normal state now is a no-go for me.
Also, you can't just randomly change the behavior of ToolButtonStyle,
i
hpereiradacosta added a comment.
Hello Roman,
I disagree that the current toolbutton design "doesn't fit the overall
design". It is (to me at least) consistent with the widget style (in e.g.
toolbars), and all the other "squarish" elements of breeze.
On the contrary, I would find the
13 matches
Mail list logo
