[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D4821#91406, @fvogt wrote: > In https://phabricator.kde.org/D4821#91393, @hein wrote: > > > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > > > If this is outstandin

[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D4821#91393, @hein wrote: > > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. > > If this is outstanding, maybe add a FIXME TODO so we don't forget ...? Yes, but that can

[Differential] [Commented On] D4821: Implement manual focus on click

2017-03-01 Thread Eike Hein
hein added a comment. > On Wayland screen locker is initially focused but clicking on different screens doesn't focus them. If this is outstanding, maybe add a FIXME TODO so we don't forget ...? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL P

[Differential] [Commented On] D4821: Implement manual focus on click

2017-02-28 Thread Fabian Vogt
fvogt added a comment. I finally figured the issue out. Newly appearing windows try to steal focus, which makes m_focusedLockWindow actually wrong. That explains why it works only for some and only for some setups... I'll try to fix that by adding setAttribute(Qt::WA_ShowWithoutAc

[Differential] [Commented On] D4821: Implement manual focus on click

2017-02-27 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D4821#90657, @graesslin wrote: > Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Would that really work for changes in x11locker.cpp as well? it's

[Differential] [Commented On] D4821: Implement manual focus on click

2017-02-27 Thread Martin Gräßlin
graesslin added a comment. Just as an fyi: in the build tree there is a test app which does the complete locking without the need for restart the session. Overall I think that the problem might also be in the greeter. On Wayland we have the same issue, which could indicate a problem in t

[Differential] [Commented On] D4821: Implement manual focus on click

2017-02-27 Thread Fabian Vogt
fvogt added a comment. This is weird: While the fix works absolutely fine (and reliably) for me on my primary user account, it does not have any effect for a different user around and @broulik Even weirder: I cannot reproduce the original bug in any of my VMs using multihead QXL...