graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin.
REVISION SUMMARY If KWin fails to start the Wayland server due to XDG_RUNTIME_DIR not being set, kwin_wayland should terminate with an error condition but not crash. This change makes sure that KWin detects that the Wayland server does not work and terminates the startup early and ensures that it doesn't crash while going down. An error message is shown that we could not create the Wayland server. TEST PLAN Test case added which verifies that WaylandServer fails to init. Manual testing that kwin_wayland exits with error 1. REPOSITORY rKWIN KWin BRANCH no-xdg-runtime-dir REVISION DETAIL https://phabricator.kde.org/D2078 AFFECTED FILES autotests/integration/CMakeLists.txt autotests/integration/debug_console_test.cpp autotests/integration/decoration_input_test.cpp autotests/integration/dont_crash_aurorae_destroy_deco.cpp autotests/integration/dont_crash_cancel_animation.cpp autotests/integration/dont_crash_empty_deco.cpp autotests/integration/dont_crash_glxgears.cpp autotests/integration/dont_crash_no_border.cpp autotests/integration/input_stacking_order.cpp autotests/integration/internal_window.cpp autotests/integration/lockscreen.cpp autotests/integration/maximize_test.cpp autotests/integration/move_resize_window_test.cpp autotests/integration/no_xdg_runtime_dir_test.cpp autotests/integration/plasma_surface_test.cpp autotests/integration/plasmawindow_test.cpp autotests/integration/platformcursor.cpp autotests/integration/pointer_input.cpp autotests/integration/quick_tiling_test.cpp autotests/integration/scene_qpainter_test.cpp autotests/integration/shade_test.cpp autotests/integration/shell_client_test.cpp autotests/integration/start_test.cpp autotests/integration/struts_test.cpp autotests/integration/touch_input_test.cpp autotests/integration/transient_no_input_test.cpp autotests/integration/transient_placement.cpp autotests/integration/xclipboardsync_test.cpp main_wayland.cpp wayland_server.cpp wayland_server.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel