[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-20 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwinqml.cpp:63 > +[this] (ShellSurfaceInterface *shellSurface) { > +qDebug() << "Shell surface created"; > +m_surface = s

[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-01 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision now requires changes to proceed. I would like to see a test case which verifies that it starts the kwin_wayland instance and terminates it again. INLINE COMMENTS > kw

[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

2016-07-01 Thread bshah (Bhushan Shah)
bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kwinqml.cpp:73-75 > +QProcess *kwinWayland = new QProcess(this); > +kwinWayland->setProcessChannelMode(QProcess::ForwardedChannels); > +kwinWayland->

[Differential] [Requested Changes To] D1989: Introduce QQuickItem to nest kwin_wayland

2016-06-29 Thread bshah (Bhushan Shah)
bshah requested changes to this revision. bshah added a reviewer: bshah. This revision now requires changes to proceed. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1989 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, #plas