davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > mart wrote in shellcorona.cpp:1922 > cont is being deleted there, i'm making sure it's not in > m_desktopContainments anymore for not even an instant. > desktopContainmentDestroyed wasn't even called before as it's disconnecting > the connection before destroying So to make it clear what this code is actually doing: we're disconnecting from a method that automatically does cleanup ..and now you're adding back in *the exact same cleanup* manually What is the point of that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3981 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
