Re: [Kourse 3] Fixing krazy2 issues

2009-01-16 Thread Philipp Klaffert
Am 16. Januar 2009 00:21 schrieb Aaron J. Seigo ase...@kde.org: On Thursday 15 January 2009, Philipp Klaffert wrote: I've now swapped all the Strings with constants and so, just 3 objects an no more krazy complaining for at least these issues. great; ready to commit! =)) -- Aaron J.

Re: [Kourse 3] Fixing krazy2 issues

2009-01-16 Thread Aaron J. Seigo
On Friday 16 January 2009, Philipp Klaffert wrote: Thank you for commiting the patch!! thanks for putting the effort into writing it =) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software

RE: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Hey 2009/1/15 Philipp Klaffert pklaffert at googlemail.com https://mail.kde.org/mailman/listinfo/plasma-devel: * license and copyright issues and you can find the patch in the attachement ** of this Mail. * I think you forgot to attach the patch hehe =) Cheers and I think you are right...

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Dominik Haumann
Hi Philipp, On Thursday 15 January 2009, Philipp Klaffert wrote: @@ -54,7 +53,7 @@ return true; } -if (!name.startsWith(Timeline:) !name.startsWith(TimelineWithFriends:) !name.startsWith(Profile:)) { +if (!name.startsWith(QString(Timeline:))

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Hi Dominik, thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I won't decide which way is better. I think the explicit conversion of these Strings makes the understanding of the

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Philipp Klaffert wrote: thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I won't decide which way is better. I think the explicit conversion of

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Philipp Klaffert
Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo ase...@kde.org: On Thursday 15 January 2009, Philipp Klaffert wrote: thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with readability but I

Re: [Kourse 3] Fixing krazy2 issues

2009-01-15 Thread Aaron J. Seigo
On Thursday 15 January 2009, Philipp Klaffert wrote: I've now swapped all the Strings with constants and so, just 3 objects an no more krazy complaining for at least these issues. great; ready to commit! =)) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA