Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-09 Thread Patrick Aljord
On Sat, Aug 8, 2009 at 1:56 PM, Chani chan...@gmail.com wrote: kompare won't load the diff for some reason... I used the techbase tutorial here http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patch and used that command: svn diff --diff-cmd diff --extensions -u -p

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-09 Thread Chani
On August 9, 2009 12:42:30 Patrick Aljord wrote: On Sat, Aug 8, 2009 at 1:56 PM, Chani chan...@gmail.com wrote: kompare won't load the diff for some reason... I used the techbase tutorial here http://techbase.kde.org/Contribute/Send_Patches#Creating_a_Simple_File_Patc h and used that

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-09 Thread Patrick Aljord
http://reviewboard.kde.org/r/1248/ here is the diff with the imagebinPrivacy always as int. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-09 Thread Patrick Aljord
oops, forgot to hit the publish button, should be up now http://reviewboard.kde.org/r/1248/ On Sun, Aug 9, 2009 at 3:00 PM, Patrick Aljordpatc...@gmail.com wrote: http://reviewboard.kde.org/r/1248/ here is the diff with the imagebinPrivacy always as int.

[PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Patrick Aljord
Hey all, This is my first patch, it just adds posting private picture to imagebin.ca from the pastebin plasmoid as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Cheers, Pat Index: applets/pastebin/pastebin.cpp

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Chani
On August 8, 2009 09:40:28 Patrick Aljord wrote: Hey all, This is my first patch, it just adds posting private picture to imagebin.ca from the pastebin plasmoid as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Cheers, Pat thanks for the patch :)

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Artur Souza (MoRpHeUz)
On Saturday 08 August 2009, 13:40 Patrick Aljord wrote: This is my first patch, it just adds posting private picture to imagebin.ca from the pastebin plasmoid as the title says, it needs to be applied from kdeplasma-addons, hope it works for you. Thanks for the patch! As Chani asked, can you

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Artur Souza (MoRpHeUz)
On Saturday 08 August 2009, 16:35 Chani wrote: oh. but we also have this: int imagebinPrivacy = uiServersOptions.imagebinPrivacy-currentIndex(); so, either make it always an int, or make it an enum. don't use a string. especially a string that just contains a number anyways... +1 for

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Patrick Aljord
Thanks to all for your comments. I haven't coded anything in C++ for at least 3 years so I guess it shows :) I'll send the patch with your suggestions tomorrow, in the meantime here is the screenshot http://imagebin.ca/view/fyaoR7T.html ___ Plasma-devel

Re: [PATCH] Adds posting private picture to imagebin.ca from the pastebin plasmoid

2009-08-08 Thread Chani
On August 8, 2009 18:41:32 Patrick Aljord wrote: Thanks to all for your comments. I haven't coded anything in C++ for at least 3 years so I guess it shows :) I'll send the patch with your suggestions tomorrow, in the meantime here is the screenshot http://imagebin.ca/view/fyaoR7T.html hmmm.