Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-16 Thread David Faure
On Tuesday 15 September 2009, 潘卫平(Peter Pan) wrote: > Looking forward to your code using KDirWatch on ktrashrc. I didn't say _I_ was going to do it :-) -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). _

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-14 Thread 潘卫平(Peter Pan)
David Faure 写道: > [Too much cross-posting, removing kde-devel from the CC list] > > On Wednesday 02 September 2009, 潘卫平(Peter Pan) wrote: > === >> --- trashimpl.cpp (revision 1018673) >> +++ trashimpl.cpp (working copy) >>

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-14 Thread David Faure
[Too much cross-posting, removing kde-devel from the CC list] On Wednesday 02 September 2009, 潘卫平(Peter Pan) wrote: === > --- trashimpl.cpp (revision 1018673) > +++ trashimpl.cpp (working copy) > @@ -771,6 +771,7 @@ > >

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-02 Thread Aaron J. Seigo
On September 2, 2009, Alessandro Diaferia wrote: > What about making the kioslave using KSharedConfig? that only works within the same process. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Develop

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-02 Thread Alessandro Diaferia
2009/9/2 Aaron J. Seigo > On September 2, 2009, 潘卫平(Peter Pan) wrote: > > ReparseConfiguration is expensive, but I can't find better way now. > > as long as it uses a kconfig file, i don't see another way around that. > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0

Re: [PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-02 Thread Aaron J. Seigo
On September 2, 2009, 潘卫平(Peter Pan) wrote: > ReparseConfiguration is expensive, but I can't find better way now. as long as it uses a kconfig file, i don't see another way around that. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43

[PATCH] BUG 167388 inconsistency in ~/.kde4/share/config/trashrc

2009-09-01 Thread 潘卫平(Peter Pan)
Hi, all When look into BUG 167388, I find that plasma-desktop and dolphin use kio_trash to deal with trash, and class TrashImpl is responsible to keep trashrc consistent. But if more than one kio_trash are created, inconsistency may occur, because TrashImpl doesn't make sure whether the config