Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-29 Thread Aaron J. Seigo
On Wednesday 29 July 2009, 潘卫平 wrote: Third, I set the BusyWidgest's geometry in AbstractTaskItem::drawTask(), so it can get the proper geometry. patch looks good; i only wonder if there's a better place to put the setGeometry for the busy widget than in a paintEvent, but this seems like it

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-29 Thread 潘卫平(Peter Pan)
Aaron J. Seigo 写道: On Wednesday 29 July 2009, 潘卫平 wrote: Third, I set the BusyWidgest's geometry in AbstractTaskItem::drawTask(), so it can get the proper geometry. patch looks good; i only wonder if there's a better place to put the setGeometry for the busy widget than in a paintEvent,

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-23 Thread 潘卫平(Peter Pan)
Aaron J. Seigo 写道: On Wednesday 22 July 2009, Aaron J. Seigo wrote: On Tuesday 21 July 2009, 潘卫平(Peter Pan) wrote: Do you mean that I should use Plasma::BusyWidget ? yes I made a patch using Plasma::BusyWidget, It looks fine. i wonder if it wouldn't make more sense to show it in place of

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-23 Thread Aaron J. Seigo
On Thursday 23 July 2009, 潘卫平(Peter Pan) wrote: Taht will cover the icon and looks mussy. I prefer to let it over the text. hm.. ok, how about on the right side of the button then, where the # of windows usually appears when there are several windows grouped? also as for this: +QRectF

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-22 Thread Sebastian Kügler
Hi Peter, On Saturday 18 July 2009 16:05:02 潘卫平(Peter Pan) wrote: In KDE3, when I start a programm, the taskbar-panel shows a turning-sand-clock while the programm starts. I would like that back in KDE4. I try to make a patch to fix this BUG, but I don't known how to realize a

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-22 Thread Aaron J. Seigo
On Tuesday 21 July 2009, 潘卫平(Peter Pan) wrote: Do you mean that I should use Plasma::BusyWidget ? yes I made a patch using Plasma::BusyWidget, It looks fine. i wonder if it wouldn't make more sense to show it in place of the icon instead of right over the text? also, you don't need to

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-22 Thread Aaron J. Seigo
On Wednesday 22 July 2009, Aaron J. Seigo wrote: On Tuesday 21 July 2009, 潘卫平(Peter Pan) wrote: Do you mean that I should use Plasma::BusyWidget ? yes I made a patch using Plasma::BusyWidget, It looks fine. i wonder if it wouldn't make more sense to show it in place of the icon or

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-21 Thread 潘卫平(Peter Pan)
Aaron J. Seigo 写道: On Saturday 18 July 2009, 潘卫平(Peter Pan) wrote: Any comments are warmly welcomed! how about using the standard plasma busy animation? no need for new icons and it will be consistent with everything else.

Re: [PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-20 Thread Aaron J. Seigo
On Saturday 18 July 2009, 潘卫平(Peter Pan) wrote: Any comments are warmly welcomed! how about using the standard plasma busy animation? no need for new icons and it will be consistent with everything else. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75

[PATCH] BUG 189643 Taskbar should be animated while program is starting

2009-07-18 Thread 潘卫平(Peter Pan)
Hi, all In KDE3, when I start a programm, the taskbar-panel shows a turning-sand-clock while the programm starts. I would like that back in KDE4. I try to make a patch to fix this BUG, but I don't known how to realize a turning-sand-clock effect, so I choose icons like go-up, go-next, go-down