Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Lucas Murray
On Fri, Sep 18, 2009 at 11:52 PM, Marco Martin wrote: > now the config option is managed in Options, a bit better If the patch works how you want it to work it is fine to commit. -- Lucas Murray :: http://www.undefinedfire.com GPG Fingerprint: 0B88 499E 3F5B 1405 D952 258A AD90 B4F5 90B6 3534

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Marco Martin wrote: > On Friday 18 September 2009, Marco Martin wrote: > > On Friday 18 September 2009, Lucas Murray wrote: > > > On Fri, Sep 18, 2009 at 2:31 AM, Marco Martin wrote: > > > > hi all, > > > > one of the things we need for the plasma netbook shell is to h

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Marco Martin wrote: > On Friday 18 September 2009, Lucas Murray wrote: > > On Fri, Sep 18, 2009 at 2:31 AM, Marco Martin wrote: > > > hi all, > > > one of the things we need for the plasma netbook shell is to have > > > windows fullscreen most of the time, so be maximi

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Lucas Murray wrote: > On Fri, Sep 18, 2009 at 2:31 AM, Marco Martin wrote: > > hi all, > > one of the things we need for the plasma netbook shell is to have windows > > fullscreen most of the time, so be maximized and without borders (title > > and controls to unmaximi

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Lucas Murray
On Fri, Sep 18, 2009 at 5:47 PM, Marco Martin wrote: > uuh, so KDecoration::borders() should be no longer a pure virtual? If that's the only way to implement it then it cannot be done as all decorations override the function anyway. As some popular decorations use KDecoration directly there is n

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Lucas Murray wrote: > On Fri, Sep 18, 2009 at 4:28 PM, Marco Martin wrote: > > well, exactly what is done in this patch, is just in the > > kcommondecoration superclass to no be specific to one single decoration. > > In that case: > > 1) The setting would be better cal

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Lucas Murray
On Fri, Sep 18, 2009 at 4:28 PM, Marco Martin wrote: > well, exactly what is done in this patch, is just in the kcommondecoration > superclass to no be specific to one single decoration. In that case: 1) The setting would be better called "borderlessMaximizedWindows". 2) Layout metric calculatio

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Lucas Murray wrote: > On Fri, Sep 18, 2009 at 9:11 AM, Lucas Murray wrote: > >> anoter idea could be modifying window rules to match also geometry, > >> maximized state etc.. > > > > This is probably better. > > Yet another idea is to just modify a decoration so that

Re: [PATCH] remove borders on maximized windows

2009-09-18 Thread Marco Martin
On Friday 18 September 2009, Lucas Murray wrote: > On Fri, Sep 18, 2009 at 2:31 AM, Marco Martin wrote: > > hi all, > > one of the things we need for the plasma netbook shell is to have windows > > fullscreen most of the time, so be maximized and without borders (title > > and controls to unmaximi

Re: [PATCH] remove borders on maximized windows

2009-09-17 Thread Nuno Pinheiro
A Sexta, 18 de Setembro de 2009 02:14:09 Lucas Murray vocĂȘ escreveu: > On Fri, Sep 18, 2009 at 9:11 AM, Lucas Murray wrote: > >> anoter idea could be modifying window rules to match also geometry, > >> maximized state etc.. > > > > This is probably better. > > Yet another idea is to just modify

Re: [PATCH] remove borders on maximized windows

2009-09-17 Thread Lucas Murray
On Fri, Sep 18, 2009 at 9:11 AM, Lucas Murray wrote: >> anoter idea could be modifying window rules to match also geometry, maximized >> state etc.. > > This is probably better. Yet another idea is to just modify a decoration so that doesn't have a title bar when maximised. -- Lucas Murray ::

Re: [PATCH] remove borders on maximized windows

2009-09-17 Thread Lucas Murray
On Fri, Sep 18, 2009 at 2:31 AM, Marco Martin wrote: > hi all, > one of the things we need for the plasma netbook shell is to have windows > fullscreen most of the time, so be maximized and without borders (title and > controls to unmaximize and close are directly into the panel) but keeping the >

[PATCH] remove borders on maximized windows

2009-09-17 Thread Marco Martin
hi all, one of the things we need for the plasma netbook shell is to have windows fullscreen most of the time, so be maximized and without borders (title and controls to unmaximize and close are directly into the panel) but keeping the possibility to have not maximized windows with normal borde