Re: Critical Denial of Service bugs in Discover

On Mon, Mar 7, 2022 at 1:16 PM Aleix Pol wrote: > > On Sat, Mar 5, 2022 at 8:36 AM Ben Cooksley wrote: > >> On Fri, Mar 4, 2022 at 12:49 AM Aleix Pol wrote: >> >>> I'd say wireshark is too low level for what the problem is here. We are >>> talking about having too many HTTP requests for

Re: Critical Denial of Service bugs in Discover

On Sat, Mar 5, 2022 at 8:36 AM Ben Cooksley wrote: > On Fri, Mar 4, 2022 at 12:49 AM Aleix Pol wrote: > >> I'd say wireshark is too low level for what the problem is here. We are >> talking about having too many HTTP requests for specific URLs. >> > > Correct, I guess the difference in our

Re: Critical Denial of Service bugs in Discover

On Fri, Mar 4, 2022 at 12:49 AM Aleix Pol wrote: > I'd say wireshark is too low level for what the problem is here. We are > talking about having too many HTTP requests for specific URLs. > Correct, I guess the difference in our approaches comes from a "before release" to a "monitor after

Re: Critical Denial of Service bugs in Discover

I'd say wireshark is too low level for what the problem is here. We are talking about having too many HTTP requests for specific URLs. I can think two main measures: - Trigger an alarm (an e-mail notification?) if there's a specific UserAgent that has a specific portion of the queries we have in

Re: Critical Denial of Service bugs in Discover

On Thu, Mar 3, 2022 at 8:41 AM Aleix Pol wrote: > (dropping the distros list) > > @sysadmin have you been able to look into any tools we devs can have to > make sure this situation doesn't repeat in the future? > Hi Aleix, To be honest i've been struggling to think of ways that we could detect

Re: Critical Denial of Service bugs in Discover

(dropping the distros list) @sysadmin have you been able to look into any tools we devs can have to make sure this situation doesn't repeat in the future? Aleix On Thu, Feb 10, 2022 at 1:10 PM Aleix Pol wrote: > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > > > > > On Thu, Feb

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 21:54:13 CET schrieb Fabian Vogt: > Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > > The first URL is used by kfontinst.knsrc from plasma-workspace: > > >

Re: Critical Denial of Service bugs in Discover

ystem is intended to serve downloads of KDE software and > associated data files to distributors and end users. These are actions that > are expected to: > > a) Be undertaken on an infrequent basis; and > > b) Be undertaken as a result of user initiated action (such as clicking > a dow

Re: Critical Denial of Service bugs in Discover

re actions that are expected > to: > a) Be undertaken on an infrequent basis; and > b) Be undertaken as a result of user initiated action (such as clicking a > download link) > > It was never intended to be used to serve configuration data files to end > user systems. We have autoc

Re: Critical Denial of Service bugs in Discover

ote that I do not believe in temporary fixes for any issue, as they often become permanent fixes - and a cluster of cloud nodes would have to remain around for many months if not longer had I not aggressively pushed for the fixes to be backported. Case in point here is Plasma - several of the ap

Re: Critical Denial of Service bugs in Discover

On Thu, Feb 10, 2022 at 1:11 PM Aleix Pol wrote: > > On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > > > > > On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: > >> > >> [Snip] > >> > >> We still haven't discussed here is how to prevent this problem from > >> happening again. > >> >

Re: Critical Denial of Service bugs in Discover

On Fri, Feb 11, 2022 at 10:22 AM Fabian Vogt wrote: > Moin, > > Am Sonntag, 6. Februar 2022, 21:54:13 CET schrieb Fabian Vogt: > > Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > > > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt > wrote: > > > > The first URL is used by

Re: Critical Denial of Service bugs in Discover

On Thu, Feb 10, 2022 at 11:05 AM Ben Cooksley wrote: > > > > On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: >> >> [Snip] >> >> We still haven't discussed here is how to prevent this problem from >> happening again. >> >> If we don't have information about what is happening, we cannot fix

Re: Critical Denial of Service bugs in Discover

On Thu, Feb 10, 2022 at 8:20 AM Aleix Pol wrote: > [Snip] > > We still haven't discussed here is how to prevent this problem from > happening again. > > If we don't have information about what is happening, we cannot fix > problems. > Part of the issue here is that the problem only came to

Re: Critical Denial of Service bugs in Discover

On Tue, Feb 8, 2022 at 7:00 PM Ben Cooksley wrote: > > On Tue, Feb 8, 2022 at 4:24 AM Aleix Pol wrote: >> >> On Sat, Feb 5, 2022 at 10:16 PM Ben Cooksley wrote: >> > >> > Hi all, >> > >> > Over the past week or so Sysadmin has been dealing with an extremely high >> > volume of traffic directed

Re: Critical Denial of Service bugs in Discover

On Tue, Feb 8, 2022 at 4:24 AM Aleix Pol wrote: > On Sat, Feb 5, 2022 at 10:16 PM Ben Cooksley wrote: > > > > Hi all, > > > > Over the past week or so Sysadmin has been dealing with an extremely > high volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > > >

Re: Critical Denial of Service bugs in Discover

On Sat, Feb 5, 2022 at 10:16 PM Ben Cooksley wrote: > > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it is directed at

Re: Critical Denial of Service bugs in Discover

Moin, Am Sonntag, 6. Februar 2022, 19:27:11 CET schrieb Ben Cooksley: > On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > > The first URL is used by kfontinst.knsrc from plasma-workspace: > > ProvidersUrl=https://distribute.kde.org/khotnewstuff/fonts-providers.xml > > > > The second URL is

Re: Critical Denial of Service bugs in Discover

Hi, Am Samstag, 5. Februar 2022, 22:16:28 CET schrieb Ben Cooksley: > Hi all, > > Over the past week or so Sysadmin has been dealing with an extremely high > volume of traffic directed towards both download.kde.org and > distribute.kde.org. > > This traffic volume is curious in so far that it

Re: Critical Denial of Service bugs in Discover

On zaterdag 5 februari 2022 22:16:28 CET Ben Cooksley wrote: > This indicates that the bug lies solely within Plasma's > Discover component - more precisely it's updater. For those responsible with that component, here some ideas on how this can be fixed from a seasoned software dev. *

Re: Critical Denial of Service bugs in Discover

On Sun, Feb 6, 2022 at 1:07 PM Fabian Vogt wrote: > Hi, > > Am Samstag, 5. Februar 2022, 22:16:28 CET schrieb Ben Cooksley: > > Hi all, > > > > Over the past week or so Sysadmin has been dealing with an extremely high > > volume of traffic directed towards both download.kde.org and > >

Critical Denial of Service bugs in Discover

Hi all, Over the past week or so Sysadmin has been dealing with an extremely high volume of traffic directed towards both download.kde.org and distribute.kde.org. This traffic volume is curious in so far that it is directed at two paths specifically: -

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On 4/12/21 12:57 PM, Ben Cooksley wrote: On Tue, 13 Apr 2021, 6:04 am Nate Graham, Thanks for the explanation. Can I ask you to do your magic to silently move all bugs in the Klipper product to the Plasmashell | Clipboard component? Looks like it's about 100 bugs. We certainly

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

icator > > among others. > > > > It also has spillover implications to our mailing lists (which use a > > separate server for handling their email) as all actions that take place > > on Bugzilla lead to an email being sent to the kde-bugs-d...@kde.org > > <mailto:kde

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

ck against Bugzilla will also block email from Identity, Gitlab and Phabricator among others. It also has spillover implications to our mailing lists (which use a separate server for handling their email) as all actions that take place on Bugzilla lead to an email being sent to the kde-bugs-d.

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

server - so a block against Bugzilla will also block email from Identity, Gitlab and Phabricator among others. It also has spillover implications to our mailing lists (which use a separate server for handling their email) as all actions that take place on Bugzilla lead to an email being sent to t

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On Mon, Apr 12, 2021 at 6:01 PM David Edmundson wrote: > > On Mon, Apr 12, 2021 at 4:21 PM Nate Graham wrote: > > > > > > > > On 4/12/21 9:15 AM, David Edmundson wrote: > > > No objections. > > > > > > Be sure to CC sysadmins before doing bulk moves. > > > > Saying what? Also what qualifies as

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On Mon, Apr 12, 2021 at 4:21 PM Nate Graham wrote: > > > > On 4/12/21 9:15 AM, David Edmundson wrote: > > No objections. > > > > Be sure to CC sysadmins before doing bulk moves. > > Saying what? Also what qualifies as bulk? Please move Product blah to blah. They have some secret bugzilla that

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On 4/12/21 9:15 AM, David Edmundson wrote: No objections. Be sure to CC sysadmins before doing bulk moves. Saying what? Also what qualifies as bulk? Nate

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

No objections. Be sure to CC sysadmins before doing bulk moves. David

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

Ping on this. After having triaged all Klipper bugs recently, and given that it is basically a Plasma service now, I don't see the advantage of having multiple components with the product anymore, or even using a separate product at all. I would like to propose moving all Klipper bugs

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

Then perhaps all of the bugs (not just applet bugs) could be moved into a new 'klipper' component within plasmashell? The distinction between common code and the applet itself is somewhat amorphous now because the applet is the only UI people see. Nate On 8/10/20 11:48 AM, David Edmundson

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

Right now the component "plasma-widget" is filled with bugs about common klipper code. If we move the component to plasmashell that's not going to change. Unless you have a new idea on making it really "applet only" we're ultimately just going to spread bug reports o

Re: Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

On Fri, Aug 7, 2020 at 7:04 PM Nate Graham wrote: > > [Gardening team hat on] > > Klipper bugs currently live in the Klipper product, not as a product > inside the Plasmashell component like other first-party > shipped-by-default applets. As a result these bugs seem to have

Proposal: move Klipper | Plasma Applet bugs into Plasmashell product

[Gardening team hat on] Klipper bugs currently live in the Klipper product, not as a product inside the Plasmashell component like other first-party shipped-by-default applets. As a result these bugs seem to have been overlooked by bug triaging efforts, because the product currently has 159

VHI bugs

Hello Plasma devs! We've had a saved search for VHI priority bugs for a little while which can guide our bugfixing efforts. In the interests of clarifying things, it has now been replaced with two saved searches: One for high priority regressions: https://bugs.kde.org/buglist.cgi?cmdtype

D29234: Fix various bugs introduced with heading

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf6b8353a73f: Fix various bugs introduced with heading (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82062=82065

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 82062. niccolove added a comment. Remove inHistory change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=82060=82062 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added a comment. Sorry, I'll make a different patch for that REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29234: Fix various bugs introduced with heading

broulik added a comment. > I added one last thing Can we please not mix behavior changes into a patch that fixes bugs and regressions. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-de

D29234: Fix various bugs introduced with heading

niccolove requested review of this revision. niccolove marked 4 inline comments as done. niccolove added a comment. I added one last thing: I feel like it was not a good idea to show the heading in history for notifications that are not in group. I added a inHistory bool, false by default,

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 82060. niccolove added a comment. Address feedback and add inHistory bool REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81791=82060 BRANCH fix_notifications (branched from master) REVISION

D29234: Fix various bugs introduced with heading

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:118 > +Layout.preferredWidth: notificationHeading.implicitWidth > +id: headingElement > + Put `id` at the top >

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81791. niccolove added a comment. Fix very long application names REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81750=81791 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81750. niccolove added a comment. Fix very long notification titles REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81748=81750 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81748. niccolove added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81733=81748 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > NotificationItem.qml:116 > +Layout.fillWidth: true > +implicitHeight: !notificationItem.inGroup ? > notificationHeading.implicitHeight : 0 > + When `inGroup` the height will be zero so you effectively leak the item contents

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81733. niccolove added a comment. Move lineSvg to root element REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81732=81733 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81732. niccolove added a comment. Fix visibility REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81730=81732 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ah, there's a mistake on visibility, just a sec REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29234: Fix various bugs introduced with heading

niccolove added a comment. Keyboard navigation is now working again; however, pressing tab to focus buttons seem to no longer be possible after this patch; looking at the code, I'm given the impression that it was true before porting notifications to page as well. Is that correct, or should

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81730. niccolove added a comment. Fix keyboard navigation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81727=81730 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added a comment. I used the Svg instead of the plasmoidHeading to avoid using a Control. User-wise, it works correctly, but can I get your opinion code-wise? INLINE COMMENTS > broulik wrote in FullRepresentation.qml:454 > Move the `Svg` somewhere outside the delegate, I don't want

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81727. niccolove added a comment. Remove plasmoidHeading element as it's a control REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81389=81727 BRANCH fix_notifications (branched from master)

D29234: Fix various bugs introduced with heading

broulik added inline comments. INLINE COMMENTS > niccolove wrote in NotificationItem.qml:125 > I originally did this but I had a problem. It displays and works just as > good, but it will throw a "you are using anchors in layouts" error in the > console. Even though I disable the anchors in

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81389. niccolove added a comment. Fix close button not clickable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81372=81389 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove added inline comments. INLINE COMMENTS > broulik wrote in NotificationItem.qml:125 > Please use one of the `State` below for `inGroup` state I originally did this but I had a problem. It displays and works just as good, but it will throw a "you are using anchors in layouts" error in

D29234: Fix various bugs introduced with heading

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > FullRepresentation.qml:454 > elementId: "vertical-line" > -svg:

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81372. niccolove added a comment. Fix spacing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81368=81372 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove planned changes to this revision. niccolove added a comment. Ahh, this adds top margin in history. Let me fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29234 To: niccolove, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n,

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81368. niccolove added a comment. Missing space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81367=81368 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

ngraham added inline comments. INLINE COMMENTS > NotificationItem.qml:441 > when: notificationItem.inGroup > + > PropertyChanges { unrelated change > NotificationItem.qml:140 > + > +MouseArea{ > +anchors.fill: parent missing space before the curly

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81367. niccolove added a comment. unrelated pt3 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81366=81367 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81366. niccolove added a comment. Unrelated pt2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81365=81366 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81365. niccolove added a comment. Remove unrelated REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81364=81365 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY This fixes: - Indented notifications line (it's back) - Heading being non-clickable - Buttons not being right-aligned

Re: Proposal to centralize KCM bugs inside the systemsettings product

On 3/16/20 8:03 AM, David Edmundson wrote: On Mon, Mar 16, 2020 at 1:42 PM Nate Graham wrote: Hmm, you're right. I suppose the applet bugs should be moved back into print-manager then. Would you like me to do that? There are only four bugs in there so it should not generate a flood

Re: Proposal to centralize KCM bugs inside the systemsettings product

On Mon, Mar 16, 2020 at 1:42 PM Nate Graham wrote: > > On 3/12/20 10:58 AM, David Edmundson wrote: > > With one exception: print manager. > > > > The version field will not match the product version . This will be a > > problem. > > Hmm, you're right. I sup

Re: Proposal to centralize KCM bugs inside the systemsettings product

s to plasma-devel, sorry about that. >> >> FWIW the proposed changes were already made, so this is mostly for >> visibility and record-keeping at this point. >> >> Nate >> >> >> ---- Forwarded Message >> Subject: Proposal to centralize

Re: Proposal to centralize KCM bugs inside the systemsettings product

The bugs in those products that affect their KCMs were moved into the systemsettings products. fFr print-manager, bugs in the applet were moved into plasmashell. Other bugs were not moved. So it it normal that there are still bugs in print-manager, plasma-nm, etc; they are bugs that don't

Re: Proposal to centralize KCM bugs inside the systemsettings product

I still see bugs in e.g. https://bugs.kde.org/buglist.cgi?component=general_id=1723750=print-manager=--- and https://bugs.kde.org/buglist.cgi?component=general_id=1723749=plasma-nm=--- so have they been moved? I use this script to update the Bugzilla products with new versions when I make

Fwd: Proposal to centralize KCM bugs inside the systemsettings product

. Nate Forwarded Message Subject: Proposal to centralize KCM bugs inside the systemsettings product Date: Thu, 27 Feb 2020 07:42:23 -0700 From: Nate Graham Organization: kde.org To: kscreen-bugs-n...@kde.org, jgrul...@redhat.com, now...@gmail.com, plasma-b...@kde.org, albertv

D24123: [GTK3] Fix menu bugs

ngraham added a comment. Which patch does fix https://bugs.kde.org/show_bug.cgi?id=412078 then? It was listed as one of the fixed bugs in your original combined-together patch. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24123 To: cblack, #breeze, ngraham

D24123: [GTK3] Fix menu bugs

cblack added a comment. In D24123#535491 , @ngraham wrote: > Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell. This patch doesn't touch any of the style nodes that would be affecting

D24123: [GTK3] Fix menu bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R98:51384880cb21: [GTK3] Fix menu bugs (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24123?vs=66564=66570 REVISION DETAIL https

D24123: [GTK3] Fix menu bugs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Does this fix https://bugs.kde.org/show_bug.cgi?id=412078? I can't reproduce it myself so I can't tell. REPOSITORY R98 Breeze for Gtk BRANCH fix-menu-curve (branched from master)

D23261: Add option to discourage reporting bugs

fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? REPOSITORY R871

D23261: Add option to discourage reporting bugs

fsitter added a comment. You think sending your minions to insult me and then disabling my account will solve the issue? what will you do next? Disable registration so no one points out your hypocrisy? Which overlord made the decision to disable my account and for what? dont forgot to add

D23261: Add option to discourage reporting bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R871:81c4e8f53148: Add option to discourage reporting bugs (authored by broulik). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64649=64650 REVISION DETAIL

D23261: Add option to discourage reporting bugs

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D23261 To: broulik, #plasma, sitter Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela,

D23261: Add option to discourage reporting bugs

broulik updated this revision to Diff 64649. broulik added a comment. - Do nothing when shutting down in non-interactive mode REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64647=64649 REVISION DETAIL https://phabricator.kde.org/D23261

D23261: Add option to discourage reporting bugs

sitter added inline comments. INLINE COMMENTS > sitter wrote in main.cpp:225 > Surely it should also return right away if isShuttingDown down and > interaction isn't allowed, otherwise you create a dump needlessly on account > of the user not being meant to report it. What about this?

D23261: Add option to discourage reporting bugs

broulik updated this revision to Diff 64647. broulik added a comment. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. - Add i18nc REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64038=64647 REVISION DETAIL

D23261: Add option to discourage reporting bugs

sitter added inline comments. INLINE COMMENTS > broulik wrote in statusnotifier.cpp:144 > We never do that. Do we have a `@context` for that or should I just write > `i18nc("Notification text", "...")`? We do not. I always check my handy cheat sheet

D23261: Add option to discourage reporting bugs

broulik added inline comments. INLINE COMMENTS > sitter wrote in statusnotifier.cpp:144 > I care more about the context that this is a notification message than about > the brevity recommendation. We never do that. Do we have a `@context` for that or should I just write `i18nc("Notification

D23261: Add option to discourage reporting bugs

sitter added inline comments. INLINE COMMENTS > broulik wrote in statusnotifier.cpp:144 > I don't think that is neccessary, > The keep short in the buttons was mostly because back then notification > action buttons were placed on the right side of notifications and were > severly limited in

D23261: Add option to discourage reporting bugs

broulik added a comment. > Whatever happened to m_iconName? It did a `KService::serviceByStorageId(crashedApp->fakeExecutableBaseName());` lookup, e.g. for "dolphin" and doesn't find "org.kde.dolphin". So this stopped working at some point without anyone caring. INLINE COMMENTS >

D23261: Add option to discourage reporting bugs

sitter added a comment. Whatever happened to m_iconName? Code looks sound. INLINE COMMENTS > main.cpp:225 > +// For automatically restarted services, do nothing in case no > interaction is allowed > +if (!forceDialog && !interactionAllowed && restarted) { > +return 0;

D23261: Add option to discourage reporting bugs

davidedmundson added a comment. Makes sense to me. There are situations with no useful backtraces and users can't install them, but it's nice to have some feedback than just a window completely disappearing. ++ REPOSITORY R871 DrKonqi REVISION DETAIL

D23261: Add option to discourage reporting bugs

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is for vendors and environments that don't want to allow their users to report bugs

Re: Closing old Plasma 4 bugs

On vrijdag 8 juni 2018 22:37:56 CEST Nate Graham wrote: > This work is done; all the bugs and feature requests in the plasma4 > product have been closed. Hope all of your inboxes survived the onslaught! Nice! https://bugs.kde.org/weekly-bug-summary.cgi tells me User# Resolved n...@k

Re: Closing old Plasma 4 bugs

On Sat, Jun 9, 2018 at 9:06 AM, Scott Harvey wrote: > Did anyone check how much space has been freed up in the Bugzilla database? The closure of bugs doesn't archive them from the database. Once entered into the system they're in there permanently. Cheers, Ben > On Jun 8, 2018, 3:39 PM

Re: Closing old Plasma 4 bugs

On 08.06.2018 23:06, Scott Harvey wrote: Did anyone check how much space has been freed up in the Bugzilla database? None, because the bugs are still there; they just changed the status. On the other hand, we have some 2600+ less open tickets.

Re: Closing old Plasma 4 bugs

Did anyone check how much space has been freed up in the Bugzilla database? On Jun 8, 2018, 3:39 PM -0500, Nate Graham , wrote: > This work is done; all the bugs and feature requests in the plasma4 > product have been closed. Hope all of your inboxes survived the onslaught! > > Nate &

Re: Closing old Plasma 4 bugs

This work is done; all the bugs and feature requests in the plasma4 product have been closed. Hope all of your inboxes survived the onslaught! Nate On 02/21/2018 07:21 AM, Nate Graham wrote: I have also cleaned up the bug triaging page: https://community.kde.org/Guidelines_and_HOWTOs

Re: Closing old Plasma 4 bugs

regression? Christoph filed a ticket moments before your mail was sent, it should be actioned in the next few days. > > Thanks, > Elvis Cheers, Ben > > > > > >> > - Can't re-open bugs in the CLOSED state

Re: Closing old Plasma 4 bugs

ity' field. > Any objections? Hi Ben, given that no one objected, is it possible to fix this regression? Thanks, Elvis > > - Can't re-open bugs in the CLOSED state

Re: Closing old Plasma 4 bugs

than 2,500 Plasma 4 bugzilla tickets that we don't intend > >> to look at or triage. We've already prevented new tickets from being > >> filed, but it doesn't do anyone any good to just have the old ones > >> sitting there. My sense is that most of the relevant bugs and wish

Re: Closing old Plasma 4 bugs

sitting there. My sense is that most of the relevant bugs and wishlist items are already represented in the plasmashell product, so what do you think about doing a mass-close? I was thinking of closing them all with one of the following two messages (top one for bugs, bottom one for wishlist items

Re: Closing old Plasma 4 bugs

bugzilla tickets that we don't intend to look at or triage. We've already prevented new tickets from being filed, but it doesn't do anyone any good to just have the old ones sitting there. My sense is that most of the relevant bugs and wishlist items are already represented in the plasmashell product, so

  1   2   3   >