D28132: [Calculator Runner] Minor code optimisation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cd37cc6926c3: [Calculator Runner] Minor code optimisation (authored by ahmadsamir). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28132?vs=77945=77957

D28132: [Calculator Runner] Minor code optimisation

make && ctest REPOSITORY R120 Plasma Workspace BRANCH l-calcrun (branched from master) REVISION DETAIL https://phabricator.kde.org/D28132 AFFECTED FILES runners/calculator/calculatorrunner.cpp To: ahmadsamir, #plasma, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D26676: [applets/calculator] Use Qt's in-built number formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R114:a51086867c0f: [applets/calculator] Use Qts in-built number formatting (authored by davidedmundson). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26676?vs

D26676: [applets/calculator] Use Qt's in-built number formatting

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Can confirm that it fixes the bug, and the code change looks sane to me. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26676 To:

D26676: [applets/calculator] Use Qt's in-built number formatting

ngraham added a reviewer: VDG. ngraham added a comment. > Potentially this inadvertedly introduces a behaviour change > of including group separators depending on locale. > Is this a a good feature? I can't speak for everyone, but personally I like seeing the localized separators

D26676: [applets/calculator] Use Qt's in-built number formatting

* 1.3 = 6.665 REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26676 AFFECTED FILES applets/calculator/package/contents/ui/calculator.qml To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus

D26149: Change krunner calculator to display significant digits

ngraham added a comment. Thanks very much for the patch! May it be the first of many. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26149 To: lukjp, broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26149: Change krunner calculator to display significant digits

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e374492d24f4: Change krunner calculator to display significant digits (authored by lukjp, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D26149: Change krunner calculator to display significant digits

: 412627 REPOSITORY R120 Plasma Workspace BRANCH krunner-qalculate-no-interval (branched from master) REVISION DETAIL https://phabricator.kde.org/D26149 AFFECTED FILES runners/calculator/qalculate_engine.cpp To: lukjp Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus

D24325: [runners/calculator] Port old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e0f8167399ce: [runners/calculator] Port old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24325?vs=67092

D24325: [runners/calculator] Port old style connect

https://phabricator.kde.org/D24325 AFFECTED FILES runners/calculator/qalculate_engine.cpp To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts

D21983: [Kickoff/Dash] Show Calculator and Unit Converter runners

This revision was automatically updated to reflect the committed changes. Closed by commit R119:16eddf0503ba: [Kickoff/Dash] Show Calculator and Unit Converter runners (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60375

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham updated this revision to Diff 60375. ngraham added a comment. Do do it for Dash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60374=60375 BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. You can do it for Dash, though -- check that `isDash` check where it already adds some runners to the Dash it doesn't add to App Menu. I'm fine with doing it for Kicker later, but we need to resolve the design issue first so we don't create a new bug. REPOSITORY

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham updated this revision to Diff 60374. ngraham added a comment. Don't do it for Kicker REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21983?vs=60289=60374 BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

hein added a comment. Let's only do it for Kickoff and the Dash? The Kicker UI is really not made for arbitrary runners. REPOSITORY R119 Plasma Desktop BRANCH add-more-runners (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D21983 To: ngraham, #vdg, #plasma,

D21811: [Calculator] Fix popup size and minimum size for expanded version

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ba5d35dfe829: [Calculator] Fix popup size and minimum size for expanded version (authored by ngraham).

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham updated this revision to Diff 60312. ngraham added a comment. Just use a reasonable hardcoded size, per @davidedmundson's suggestion REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21811?vs=59830=60312 BRANCH fix-calculator-popup (branched

D21983: [Kicker/Kickoff/Dash] Show Calculator and Unit Converter runners

ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Calculator and Unit Converter runners are some of the most useful

D21811: [Calculator] Fix popup size and minimum size for expanded version

ngraham added inline comments. INLINE COMMENTS > broulik wrote in calculator.qml:42 > Maybe just fixing this to be `units.gridUnit` times some larger value could > fix the initial sizing I tried that earlier, but while it works for the expanded version when the widget is in the panel, it

D21811: [Calculator] Fix popup size and minimum size for expanded version

broulik added inline comments. INLINE COMMENTS > calculator.qml:42 > > width: units.gridSize * 3 > height: units.gridSize * 4 Maybe just fixing this to be `units.gridUnit` times some larger value could fix the initial sizing REPOSITORY R114 Plasma Addons REVISION DETAIL

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added a comment. Patch to fix: D21811 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel,

D21811: [Calculator] Fix popup size and minimum size for expanded version

e.png <https://phabricator.kde.org/F6890391> REPOSITORY R114 Plasma Addons BRANCH fix-calculator-popup (branched from Plasma/5.16) REVISION DETAIL https://phabricator.kde.org/D21811 AFFECTED FILES applets/calculator/package/contents/ui/calculator.qml To: ngraham, davidedmundson,

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added a comment. Ah, will fix. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

davidedmundson added a comment. Following the code will find more bugs than testing. Once you resize down the layout minimumSize (and switchSize) changes and you won't switch. F6879656: Screenshot_20190609_110121.png old code would

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in calculator.qml:39 > This will change with the font size, surely breaking it? I didn't see any regressions in testing... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham,

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

davidedmundson added inline comments. INLINE COMMENTS > calculator.qml:39 > Plasmoid.switchHeight: Layout.minimumHeight > Layout.minimumWidth: mainLayout.Layout.minimumWidth + 8 > Layout.minimumHeight: mainLayout.Layout.minimumHeight + 8 This will change with the font size,

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

This revision was automatically updated to reflect the committed changes. Closed by commit R114:987f5fe9bb12: [Calculator] Make buttons text labels scale in size along with the widget (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. That 12 is a bit random, isn't it? But glad my approach just works™ REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D21503 To: ngraham,

D21503: [Calculator] Make buttons' text labels scale in size along with the widget

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Calculator widget's button labels were not scaling in size as the widget got bigger

Re: Calculator

Hi Markus, Please file a bugzilla ticket at bugs.kde.org to request this new feature. The product is "kdeplasma-addons" FWIW, a slightly easier way to accomplish what you want to do today is to use KRunner, which has a built-in calculator that accepts pasted text at least. Nate -

Calculator

Hy Plasma Team, I use the calculator mini program and I would like to suggest an improvement. It would be nice if I could copy numbers from e.g. a website to the calculator input field then make a calculation and afterwards copy the resulting number form the calculator to e.g. an editor. Thanks

D4290: [Calculator Runner] Use "approximate" approximation mode

lueck added a comment. OK from german team REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: lueck, yurchor, kde-i18n-doc, mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D4290: [Calculator Runner] Use "approximate" approximation mode

yurchor added a comment. In https://phabricator.kde.org/D4290#98033, @broulik wrote: > @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix.

D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a subscriber: kde-i18n-doc. broulik added a comment. @kde-i18n-doc I'd like to ask for an exception to backport this fix to Plasma 5.8 (due mid of May) and Plasma 5.9 (due 25 April) as it is a rather severe, easily triggerable, memory leak/crash fix. Initially it would have

D4290: [Calculator Runner] Use "approximate" approximation mode

This revision was automatically updated to reflect the committed changes. Closed by commit R120:df7f1ed1eb7d: [Calculator Runner] Use "approximate" approximation mode (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D429

D4290: [Calculator Runner] Use "approximate" approximation mode

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces, mart Cc: mart, plasma-devel, progwolff, lesliezhai,

[Differential] [Closed] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

This revision was automatically updated to reflect the committed changes. Closed by commit R120:605fb9acd867: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Accepted] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4472 EMAIL PREFERENCES

[Differential] [Request, 9 lines] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

e results etc…) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4472 AFFECTED FILES runners/calculator/CMakeLists.txt runners/calculator/calculatorrunner.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Updated, 24 lines] D4290: [Calculator Runner] Use "approximate" approximation mode

https://phabricator.kde.org/D4290 AFFECTED FILES runners/calculator/calculatorrunner.cpp runners/calculator/calculatorrunner.h runners/calculator/qalculate_engine.cpp runners/calculator/qalculate_engine.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Requested Changes To] D4290: [Calculator Runner] Use "approximate" approximation mode

mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > qalculate_engine.cpp:103 > +// to avoid memory overflow for seemingly innocent calculations (Bug > 277011) > +

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

mart added a comment. ship it with "aproximate" text (and just 5.10) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: mart,

[Differential] [Commented On] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik added a comment. Probably needs some indication that the result is approximate: When `result.isApproximate()` returns true I'll add a (approximation) suffix or something like this – can't go into 5.9 then. REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik updated the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4290 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma_workspaces Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Request, 4 lines] D4290: [Calculator Runner] Use "approximate" approximation mode

broulik created this revision. broulik added a reviewer: Plasma: Workspaces. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The runner calculator

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

cfeck added a comment. The m_engine member is only available, when it uses the qalculate library instead of QScriptEngine. Please add the missing #ifdef ENABLE_QALCULATE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL

[Differential] [Closed] D1939: [Calculator Runner] Add "Copy to clipboard" action

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE0abe3a6dfc24: [Calculator Runner] Add "Copy to clipboard" action (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDA

[Differential] [Accepted] D1939: [Calculator Runner] Add "Copy to clipboard" action

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES

[Differential] [Commented On] D1939: [Calculator Runner] Add "Copy to clipboard" action

broulik added a comment. F152685: Screenshot_20160618_002329.png REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 24 lines] D1939: [Calculator Runner] Add "Copy to clipboard" action

AWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 AFFECTED FILES runners/calculator/calculatorrunner.cpp runners/calculator/calculatorrunner.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design

Re: Review Request 123161: Add copy and paste support for calculator widget

is a valid number BUG: 318221 Diffs (updated) - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing (updated) --- Copying: *) Tried copying entered numbers and results - works

Re: Review Request 123161: Add copy and paste support for calculator widget

On März 27, 2015, 11:46 nachm., David Edmundson wrote: applets/calculator/package/contents/ui/calculator.qml, line 220 https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line220 I'm not convinced this is going to work. You'll update the display

Re: Review Request 123161: Add copy and paste support for calculator widget

On March 27, 2015, 11:46 p.m., David Edmundson wrote: applets/calculator/package/contents/ui/calculator.qml, line 220 https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line220 I'm not convinced this is going to work. You'll update the display

Re: Review Request 123161: Add copy and paste support for calculator widget

Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff

Re: Review Request 123161: Add copy and paste support for calculator widget

is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing --- Copying: *) Tried copying entered numbers and results - works for me

Review Request 123161: Add copy and paste support for calculator widget

/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml

Re: Review Request 123161: Add copy and paste support for calculator widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/#review78129 --- applets/calculator/package/contents/ui/calculator.qml (line

Review Request 120037: Implement scientific notation for the calculator

-addons Description --- Also solves the problem with the result not fitting in the display Diffs - applets/calculator/package/contents/ui/calculator.qml 7cb16486513cf5813612dddf0286ae7af7d48a7d Diff: https://git.reviewboard.kde.org/r/120037/diff/ Testing --- Works well, except

Re: Review Request 120037: Implement scientific notation for the calculator

/ --- (Updated Sept. 2, 2014, 5:18 p.m.) Review request for Plasma and David Edmundson. Repository: kdeplasma-addons Description --- Also solves the problem with the result not fitting in the display Diffs - applets/calculator/package

Re: Review Request 120037: Implement scientific notation for the calculator

marked as submitted. Review request for Plasma and David Edmundson. Repository: kdeplasma-addons Description --- Also solves the problem with the result not fitting in the display Diffs - applets/calculator/package/contents/ui/calculator.qml

Review Request 119902: Port calculator to GridLayout and use row/colSpan

Description --- Port calculator to GridLayout and use row/colSpan Instead of placeholders, removes custom buttonWidth/height calculation Diffs - applets/calculator/package/contents/ui/calculator.qml 3055d3e Diff: https://git.reviewboard.kde.org/r/119902/diff/ Testing

Re: Review Request 119902: Port calculator to GridLayout and use row/colSpan

.) Review request for Plasma and Bhushan Shah. Repository: kdeplasma-addons Description --- Port calculator to GridLayout and use row/colSpan Instead of placeholders, removes custom buttonWidth/height calculation Diffs - applets/calculator/package/contents/ui

Re: Review Request 119902: Port calculator to GridLayout and use row/colSpan

marked as submitted. Review request for Plasma and Bhushan Shah. Repository: kdeplasma-addons Description --- Port calculator to GridLayout and use row/colSpan Instead of placeholders, removes custom buttonWidth/height calculation Diffs - applets/calculator/package/contents/ui

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

/ --- (Updated Dec. 31, 2013, 3:06 a.m.) Review request for Plasma. Bugs: 321803 http://bugs.kde.org/show_bug.cgi?id=321803 Repository: kde-workspace Description --- The current calculator krunner checks

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

marked as submitted. Review request for Plasma. Bugs: 321803 http://bugs.kde.org/show_bug.cgi?id=321803 Repository: kde-workspace Description --- The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

.) Review request for Plasma. Bugs: 321803 http://bugs.kde.org/show_bug.cgi?id=321803 Repository: kde-workspace Description --- The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters. Instead

Review Request 114746: [calculator runner] Replace regexp with explicit character category check

/show_bug.cgi?id=321803 Repository: kde-workspace Description --- The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters. Instead of increasing regexp complexity, I simply use the QChar category functions to check

Re: Review Request 114746: [calculator runner] Replace regexp with explicit character category check

--- whitespace Bugs: 321803 http://bugs.kde.org/show_bug.cgi?id=321803 Repository: kde-workspace Description --- The current calculator krunner checks for textual input using a simple [a-zA-Z] regexp, which is going to fail for non-latin letters. Instead of increasing regexp

Re: Review Request 113504: Fix krunner calculator letter check

.) Review request for kde-workspace and Plasma. Bugs: 326059 http://bugs.kde.org/show_bug.cgi?id=326059 Repository: kde-workspace Description --- The calculator runner now supports the syntax without the '=', so you can simply type in '3+5' and have the result

Re: Review Request 113504: Fix krunner calculator letter check

/ --- (Updated Oct. 30, 2013, 12:25 a.m.) Review request for kde-workspace and Plasma. Bugs: 326059 http://bugs.kde.org/show_bug.cgi?id=326059 Repository: kde-workspace Description --- The calculator runner now

Re: Review Request 113504: Fix krunner calculator letter check

marked as submitted. Review request for kde-workspace and Plasma. Bugs: 326059 http://bugs.kde.org/show_bug.cgi?id=326059 Repository: kde-workspace Description --- The calculator runner now supports the syntax without the '=', so you can simply type in '3+5' and have the result

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

Hi Paul, On Wednesday, September 11, 2013 18:03:57 Paul Rohrbach wrote: Thank you for accepting the patch :). But I can't commit it, because I don't have commit rights. As you've probably seen, I've committed the patch for you to the corresponding branches. Thanks a lot for your contribution

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112674/#review39846 --- Almost good, two nitpicks inside. applets/calculator/package

Review Request 112674: Bugfix: Make the calculator applet calculate correct

bug 313869. The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after pressing

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

should solve bug 313869. The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

marked as submitted. Review request for Plasma. Description --- This patch should solve bug 313869. The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets the calculator when pressing 'c

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correct

On Sept. 11, 2013, 5:28 p.m., Sebastian Kügler wrote: applets/calculator/package/contents/ui/calculator.qml, line 41 http://git.reviewboard.kde.org/r/112674/diff/1/?file=188980#file188980line41 Why is this change needed (operator initialized to undefined)? This should not be part

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

(updated) - Bugfix: Make the calculator applet calculate correctly Description --- This patch should solve bug 313869. The bug reported this behaviour: if you press something like 'a+b+c=', the result would be incorrect because the calculator plasmoid wrongly resets

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

because the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after pressing '='. This patch adds a variable to determine this situation correctly. This addresses bug 313869. http

Re: Review Request 112674: Bugfix: Make the calculator applet calculate correctly

the calculator plasmoid wrongly resets the calculator when pressing 'c'. The intended behaviour is that the calculation is cleared when pressing a number after pressing '='. This patch adds a variable to determine this situation correctly. This addresses bug 313869. http://bugs.kde.org

Re: Review Request: Port the Calculator applet to QML

/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - CMakeLists.txt 732145c calculator.h

Re: Review Request: Port the Calculator applet to QML

++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - CMakeLists.txt 732145c calculator.h f7339be calculator.cpp 6bc3ddc package/contents/ui/calculator.qml PRE-CREATION package/metadata.desktop PRE-CREATION plasma

Re: Review Request: Port the Calculator applet to QML

/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs

Re: Review Request: Port the Calculator applet to QML

--- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - CMakeLists.txt 732145c calculator.h f7339be calculator.cpp 6bc3ddc package/contents/ui/calculator.qml PRE-CREATION package

Re: Review Request: Port the Calculator applet to QML

request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - CMakeLists.txt 732145c calculator.h f7339be calculator.cpp 6bc3ddc package/contents/ui

Re: Review Request: Port the Calculator applet to QML

/107001/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs

Re: Review Request: Port the Calculator applet to QML

: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 2:54 a.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature

Re: Review Request: Port the Calculator applet to QML

.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - applets/calculator/CMakeLists.txt 732145c applets/calculator/calculator.h f7339be applets

Re: Review Request: Port the Calculator applet to QML

On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: applets/calculator/package/contents/ui/calculator.qml, lines 235-240 http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line235 Again my personal preference, but it cleans up your code. So here it is. I

Re: Review Request: Port the Calculator applet to QML

On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: applets/calculator/package/contents/ui/calculator.qml, lines 235-240 http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line235 Again my personal preference, but it cleans up your code. So here it is. I

Re: Review Request: Port the Calculator applet to QML

--- Resolved issues raised by Mark Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs (updated) - CMakeLists.txt 732145c calculator.h f7339be calculator.cpp 6bc3ddc package/contents

Re: Review Request: Port the Calculator applet to QML

On Nov. 6, 2012, 4:34 p.m., Mark Gaiser wrote: applets/calculator/package/contents/ui/calculator.qml, line 231 http://git.reviewboard.kde.org/r/107001/diff/4/?file=93822#file93822line231 I guess all the string values need to be wrapped in i18nc(C) .. Someone else would need

Re: Review Request: Port the Calculator applet to QML

://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter

Re: Review Request: Port the Calculator applet to QML

/ --- (Updated Nov. 6, 2012, 11:36 p.m.) Review request for Plasma. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs - CMakeLists.txt 732145c calculator.h f7339be

Re: Review Request: Port the Calculator applet to QML

--- Conformation to http://community.kde.org/Plasma/QMLStyle (The reported bug still remains, though. Will take a look ASAP) Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs (updated

Re: Review Request: Port the Calculator applet to QML

--- Corrected bug pointed by aseigo. Quicker than I thought. Description --- This diff replaces the C++ Calculator applet by its QMLfied version, which seems to be feature-par with the latter. Diffs (updated) - applets/calculator/CMakeLists.txt 732145c applets/calculator

Re: Review Request: Port the Calculator applet to QML

. in fact, pressing a number after = should be the same as first pressing AC :) great work otherwise! can't wait to see this in applets/calculator/package/contents/ui/calculator.qml http://git.reviewboard.kde.org/r/107001/#comment16613 id goes first above properties - Aaron J. Seigo On Nov

  1   2   >