This revision was automatically updated to reflect the committed changes.
Closed by commit R134:68c1aaabadf7: Removed duplicate preview screenshots
(authored by anemeth, committed by davidedmundson).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
anemeth added a comment.
I don't think I have push access.
Can you do it instead?
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson, abetts
Cc: ngraham, plasma-devel,
abetts accepted this revision.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson, abetts
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
apol added a comment.
Please land on the 5.12 branch.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
apol added a comment.
Can you push?
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot,
davidedmundson accepted this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store, davidedmundson
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts,
anemeth updated this revision to Diff 25776.
anemeth added a comment.
Checking for duplicate now added to appendIfValid() instead
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10027?vs=25774=25776
BRANCH
master
REVISION DETAIL
anemeth updated this revision to Diff 25774.
anemeth added a comment.
Now I see what you mean. :)
That makes it a lot smaller.
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10027?vs=25773=25774
BRANCH
master
REVISION DETAIL
ngraham added a comment.
In https://phabricator.kde.org/D10027#194446, @anemeth wrote:
> In https://phabricator.kde.org/D10027#194443, @apol wrote:
>
> > Please modify appendIfValid to not add duplicates.
>
>
> What do you mean?
> In what situation would it add duplicates?
anemeth added a comment.
In https://phabricator.kde.org/D10027#194443, @apol wrote:
> Please modify appendIfValid to not add duplicates.
What do you mean?
In what situation would it add duplicates?
This change is to make sure it does not add duplicates.
REPOSITORY
R134
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.
Please modify appendIfValid to not add duplicates.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol,
anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: apol, Discover Software Store.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10027
To: anemeth, apol, #discover_software_store
Cc:
anemeth created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
anemeth requested review of this revision.
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10027
14 matches
Mail list logo