D10083: [Look and Feel] Reverse the button order

safaalfulaij abandoned this revision. safaalfulaij added a comment. Thanks for making stuff consistent! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: ngraham, abetts, davidedmundson, plasma-devel, GB_2,

D10083: [Look and Feel] Reverse the button order

abetts added a comment. In D10083#384946 , @ngraham wrote: > This is obsolete now since the button layout was recently made consistent across all KCMs (we put everything on the right). You can Abandon this. Agreed REPOSITORY R119

D10083: [Look and Feel] Reverse the button order

ngraham added a comment. This is obsolete now since the button layout was recently made consistent across all KCMs (we put everything on the right). You can Abandon this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma,

D10083: [Look and Feel] Reverse the button order

abetts added a comment. Not sure it is redundant but it should follow what the mockups in pholio are saying. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: abetts, davidedmundson, plasma-devel, ragreen,

D10083: [Look and Feel] Reverse the button order

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Is this now redundant when this KCM was remodelled ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij,

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25924. safaalfulaij added a comment. Align the warning text to the right REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25902=25924 BRANCH master REVISION DETAIL

D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Yes I do. But shall we ask VDG or not? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10083: [Look and Feel] Reverse the button order

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Do you have commit access? REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson

D10083: [Look and Feel] Reverse the button order

safaalfulaij updated this revision to Diff 25902. safaalfulaij added a comment. Leftover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10083?vs=25901=25902 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10083 AFFECTED FILES

D10083: [Look and Feel] Reverse the button order

safaalfulaij added a comment. Look and feel: F5673030: Screenshot_٢٠١٨٠١٢٤_٢١٠٧٠٢.png Other KCMs: F5673029: Screenshot_٢٠١٨٠١٢٤_٢١٠٧١٠.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10083: [Look and Feel] Reverse the button order

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY The look and feel KCM is using a different button