D10197: Fix krunner's alt+f2 on wayland

meven added inline comments. INLINE COMMENTS > view.cpp:247 > -m_plasmaShellSurface->setPanelTakesFocus(true); > -m_plasmaShellSurface->setRole(PlasmaShellSurface::Role::Panel); > -//this should be on showEvent, but it was too soon so none of > those had any

D10197: Fix krunner's alt+f2 on wayland

apol closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. To ensure we don't forget about it I created: https://bugs.kde.org/show_bug.cgi?id=389964 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson,

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. As the commit went into the 5.12 branch we cannot build up on any functionality not yet available in Dialog. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham,

D10197: Fix krunner's alt+f2 on wayland

davidedmundson added a comment. The old code is clearly wrong. It calls Dialog::event(event); that will set up a shellsurface in the expose event Then we process further and set up a shell surface in the expose event PlasmaShellSurfaces are shared, but you still have two

D10197: Fix krunner's alt+f2 on wayland

apol added a comment. Feel free to revert and reopen the bug: https://bugs.kde.org/show_bug.cgi?id=385693 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: graesslin, broulik, ngraham, davidedmundson,

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. I really think this needs to be reverted. Krunner must be a dock, it must be set to windows go below and it must take focus. This is all functionality not provided by Plasma::Dialog. Just removing the code doesn't work unfortunately. I have a hard time

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. In https://phabricator.kde.org/D10197#201733, @apol wrote: > In https://phabricator.kde.org/D10197#200479, @graesslin wrote: > > > I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to

D10197: Fix krunner's alt+f2 on wayland

apol added a comment. In https://phabricator.kde.org/D10197#200479, @graesslin wrote: > I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without

D10197: Fix krunner's alt+f2 on wayland

graesslin reopened this revision. graesslin added a comment. This revision is now accepted and ready to land. I just verified with KWin's debug console: KRunner window is now marked as NET::Normal and not as NET::Dock. This is a problem, KRunner needs to be a dock. REPOSITORY R120 Plasma

D10197: Fix krunner's alt+f2 on wayland

graesslin added a comment. I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without being a PlasmaSurface the manual positioning cannot work. If it

D10197: Fix krunner's alt+f2 on wayland

broulik added inline comments. INLINE COMMENTS > view.cpp:246 > - > m_plasmaShellSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::WindowsGoBelow); > -m_plasmaShellSurface->setPanelTakesFocus(true); > -

D10197: Fix krunner's alt+f2 on wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fc5a45403025: Fix krunners alt+f2 on wayland (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26233=26247 REVISION DETAIL

D10197: Fix krunner's alt+f2 on wayland

davidedmundson accepted this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10197 To: apol, #plasma, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D10197: Fix krunner's alt+f2 on wayland

apol updated this revision to Diff 26233. apol added a comment. Readd the comment If somebody can test it on X11, I'd merge to 5.12. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26232=26233 BRANCH master REVISION DETAIL

D10197: Fix krunner's alt+f2 on wayland

apol updated this revision to Diff 26232. apol added a comment. Remove code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10197?vs=26230=26232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10197 AFFECTED FILES

D10197: Fix krunner's alt+f2 on wayland

davidedmundson added inline comments. INLINE COMMENTS > view.cpp:236 > if (m_plasmaShell && event->type() == QEvent::Expose) { > using namespace KWayland::Client; > auto ee = static_cast(event); This code here is definitely not designed for X11 REPOSITORY

D10197: Fix krunner's alt+f2 on wayland

apol created this revision. apol added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't go through the workaround introduced for X11 that makes it go