D10223: Improve preview thumbnail quality

hein added a comment. Thanks for your analysis! I actually did try roughly the same thing, but I thought keeping the behavior of having larger preview thumbs is nicer overall. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma, broulik,

D10223: Improve preview thumbnail quality

christianlopez added a comment. Hi, i was playing a bit with the code and i'm noticing you can get good looking images without activating the smooth and without making the thumbnails look blurry, also i think i know the reason why the thumbnails look distorted. At the line 239 in

D10223: Improve preview thumbnail quality

This revision was automatically updated to reflect the committed changes. Closed by commit R119:db42961ad4d8: Improve preview thumbnail quality (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10223?vs=26304=26589#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE

D10223: Improve preview thumbnail quality

ngraham accepted this revision. ngraham added a comment. Either way, to my mind slightly blurry is better than slightly blurry, pixellated, and bugged around the edges, so +1. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To:

D10223: Improve preview thumbnail quality

ngraham added a comment. @markg it's now about sharpness or blurring, but rather the "before" screenshot is pixellated and has weird artifacts around the edges. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma,

D10223: Improve preview thumbnail quality

markg added a comment. Hmm, weird. In my eyes the knovi thumbnail in the **before** image looks sharper than the after one. It's just blurred in the after one, not better. I'm guessing the QML smooth property has a fairly naive implementation (in Qt). REPOSITORY R119 Plasma Desktop

D10223: Improve preview thumbnail quality

ngraham added a comment. Nice! The visual artifacts here look similar or the same as ones we sometimes see in Discover and KInfoCenter at HiDPi scale factors: F5693185: Screenshot_20180122_143515.png F5693186: Pixellated logo.png

D10223: Improve preview thumbnail quality

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Please remove the unrelated changes before pushing INLINE COMMENTS > foldermodel.cpp:1896-1900 > +if (m_appletInterface) { > +Plasma::Applet *applet = >

D10223: Improve preview thumbnail quality

hein added a comment. Before: F5692985: Screenshot_20180205_203453.png After: F5692983: Screenshot_20180205_203401.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10223: Improve preview thumbnail quality

hein added a comment. In https://phabricator.kde.org/D10223#199103, @hein wrote: > In https://phabricator.kde.org/D10223#199099, @kossebau wrote: > > > Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions

D10223: Improve preview thumbnail quality

hein added a comment. In https://phabricator.kde.org/D10223#199099, @kossebau wrote: > Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;) https://www.youtube.com/watch?v=RbTUTNenvCY=9s REPOSITORY

D10223: Improve preview thumbnail quality

kossebau added a comment. Random by-passer nitpick comment: "twice as large thumbnails"... actually 4 x large in pixels, given you scale 2x in two dimensions ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10223 To: hein, #plasma Cc: kossebau,

D10223: Improve preview thumbnail quality

hein created this revision. hein added a reviewer: Plasma. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This patch does two things: - Instead of giving the KAbstractViewAdapter the actual icon size, we overprovision by giving it