D10232: Include a pixel more in the dirty area

2018-03-10 Thread Kurt Hindenburg
hindenburg added a comment. ping... have you had a chance to look at this again? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole, markg Cc: qi437103, markg, hindenburg, ngraham, plasma-devel, herrold, ZrenBot, lesliezhai,

D10232: Include a pixel more in the dirty area

2018-02-06 Thread Kurt Hindenburg
hindenburg added a comment. I now get all kinds of extra vertical lines on right side of screen and some horizontal ones near cursor using 1.3 scaling - I didn't see these before the latest patch My zsh prompt is: kurthindenburg:~/ $

D10232: Include a pixel more in the dirty area

2018-02-06 Thread Marco Martin
mart updated this revision to Diff 26640. mart added a comment. - fix cursor painting REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10232?vs=26606=26640 BRANCH phab/dirty REVISION DETAIL https://phabricator.kde.org/D10232 AFFECTED FILES

D10232: Include a pixel more in the dirty area

2018-02-05 Thread Marco Martin
mart updated this revision to Diff 26606. mart added a comment. - comments explainig the workaround REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10232?vs=26325=26606 BRANCH phab/dirty REVISION DETAIL https://phabricator.kde.org/D10232 AFFECTED

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Mark Gaiser
markg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole, markg Cc: markg, hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Mark Gaiser
markg added a comment. Please add a comment to the code for that. It might be obvious now, but the next person that looks at that code without knowledge of this change probably has a "huh, what is that?" moment and left wondering why it's done. REPOSITORY R319 Konsole REVISION DETAIL

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Kurt Hindenburg
hindenburg added a comment. so this is a workaround? Where's the actual bug at? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole Cc: hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10232: Include a pixel more in the dirty area

2018-02-01 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, Konsole. Restricted Application added projects: Plasma, Konsole. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY withfractional scaling sometimes there are visual