broulik added a comment.
Just some minor points, feel free to ignore
INLINE COMMENTS
> plotter.cpp:288
> setFlag(ItemHasContents);
> +connect(this, ::windowChanged, this, [this]() {
> +if (m_window) {
Override `QQuickItem::itemChange` instead of a `connect`
>
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2617a2ab9d47: disconnect render() on window change
(authored by mart).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10250?vs=26596=26597
REVISION DETAIL
mart retitled this revision from "track the validity of the texture" to
"disconnect render() on window change".
mart edited the summary of this revision.
REPOSITORY
R296 KDeclarative
BRANCH
phab/guardTexture2
REVISION DETAIL
https://phabricator.kde.org/D10250
To: mart, #plasma,
