This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a3e2b24b17ee: [KFileWidget] Hide places frame and header
(authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10325?vs=26642=27706
REVISION DETAIL
broulik added a comment.
If no Frameworks dev objects within next few days this will be pushed
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: apol, markg, ngraham, plasma-devel, michaelh, ZrenBot,
broulik added inline comments.
INLINE COMMENTS
> apol wrote in kfilewidget.cpp:1351
> Does it really make sense that it's a dock if it can't be interacted with?
I don't know. You can still resize the panel, I also wanted to keep the patch
as unintrusive as possible.
REPOSITORY
R241 KIO
apol added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:1351
> placesDock = new QDockWidget(i18nc("@title:window", "Places"), q);
> -placesDock->setFeatures(QDockWidget::DockWidgetClosable);
> +placesDock->setFeatures(QDockWidget::NoDockWidgetFeatures);
> +
markg added a comment.
In https://phabricator.kde.org/D10325#201884, @broulik wrote:
> > Would it be possible to show it as if it were locked? That would solve
all the issues with it, right?
>
> I don't get it. That "lock" feature is entirely a Dolphin invention. It
does exactly
broulik updated this revision to Diff 26642.
broulik retitled this revision from "RFC: [KFileWidget] Hide places frame and
header" to "[KFileWidget] Hide places frame and header".
broulik edited the test plan for this revision.
broulik added a comment.
- Add custom widget for added spacing,
