broulik added a comment.
> Would it be possible to show it as if it were locked? That would solve all
the issues with it, right?
I don't get it. That "lock" feature is entirely a Dolphin invention. It does
exactly what I do here:
void DolphinDockWidget::setLocked(bool lock)
{
mart accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham, mart
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
ngraham accepted this revision as: ngraham.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks, ngraham
Cc: markg, ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
markg added a comment.
Why does it show the panel as if it were unlocked?
Your before image looks exactly like an unlocked frame in Dolphin.
Would it be possible to show it as if it were locked? That would solve all
the issues with it, right?
REPOSITORY
R241 KIO
REVISION DETAIL
ngraham added a comment.
OK, great.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10325
To: broulik, #plasma, #vdg, #frameworks
Cc: ngraham, plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
broulik added a comment.
> Shouldn't this be controlled by System Settings > Application Style >
Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?
If that option is enabled you get a frame even with this patch. Otherwise,
the default, is nice and clean.
ngraham added a comment.
Shouldn't this be controlled by System Settings > Application Style > Widget
Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?
Otherwise, people who check that setting will have a visible frame around the
Places panel in Dolphin, but not in
broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This avoids a double "Places" header
