D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-20 Thread Friedrich W . H . Kossebau
kossebau added a comment. Quick note before I forget again: doesn't this need some Messages.sh? There are some i18n calls in the QML. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: kossebau, graesslin, abetts, broulik,

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-19 Thread Aleix Pol Gonzalez
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:1ab3d012b2d5: First approach to a plasmoid that can display the state of caps lock (authored by apol). CHANGED PRIOR

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol added a comment. F5695536: VID_20180206_195933.mp4 this is a very clunky video of what it looks like. Hope this helps. Design input very welcome. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol,

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 26665. apol added a comment. Also expose numlock, somewhat REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10337?vs=26638=26665 BRANCH arcpatch-D10337 REVISION DETAIL https://phabricator.kde.org/D10337

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D10337#202007, @apol wrote: > In https://phabricator.kde.org/D10337#201998, @graesslin wrote: > > > Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol added a comment. In https://phabricator.kde.org/D10337#201998, @graesslin wrote: > Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Martin Flöser
graesslin added a comment. Please be aware that this will not work on Wayland. The modifier state is only available to the window which currently has keyboard focus. We either need a dedicated Wayland protocol to send all modifier changes to Plasma or some other way to have KWin feed in the

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Andres Betts
abetts added a comment. Does this have a look yet? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10337 To: apol, #plasma, jriddell Cc: abetts, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:29 > + > +Plasmoid.onActivated: toggle() > + I don't see a `toggle()` function > main.qml:34 > +engine: "keystate" > +connectedSources: "Caps Lock" > +} I know QML does this magically but I'd prefer explicit

D10337: First approach to a plasmoid that can display the state of caps lock

2018-02-06 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, jriddell. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL