D10344: Create panel on current screen

mvourlakos added a comment. In D10344#299287 , @hoffmannrobert wrote: > Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38614. hoffmannrobert added a comment. Fix crash if screen numbers are not consecutive. Add ShellCorona::screenForId(int screenNum) for easy access to a panel's QScreen replacing wrong access via QGuiApplication::screens().at(screenNum).

D10344: Create panel on current screen

hoffmannrobert added a comment. Thank you. If these non-consecutive screen numbers are legitimate, then getting the QScreen via QGuiApplication::screens().at(screenNum) is wrong. I found a solution using ShellCorona::m_desktopViewforId. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10344: Create panel on current screen

mvourlakos added a comment. In D10344#299042 , @hoffmannrobert wrote: > In D10344#297751 , @hoffmannrobert wrote: > > > > > > Still looking where these screen numbers come from...

D10344: Create panel on current screen

hoffmannrobert added a comment. In D10344#297751 , @hoffmannrobert wrote: > In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig()

D10344: Create panel on current screen

hoffmannrobert marked an inline comment as done. hoffmannrobert added a comment. Sorry for the delay. In Wayland there seems to be a problem with QScreen: creating a panel on the second screen crashes plasmashell in QScreen::size(), called by PanelView::panelConfig()

D10344: Create panel on current screen

hoffmannrobert updated this revision to Diff 38411. hoffmannrobert added a comment. Regard focus window position only if manually creating panels. This fixes initial panel placement on wrong screen in dual monitor setup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D10344: Create panel on current screen

mart added a comment. btw, this was ignored for a long time as there weren't reviewers specified REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10344 To: hoffmannrobert, #plasma Cc: mart, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed,

D10344: Create panel on current screen

mart added a comment. I like the idea, needs a bit of thinking to work on wayland INLINE COMMENTS > shellcorona.cpp:1816 > +// find out current screen to create new panels on > +const QPoint cursorPos(QCursor::pos()); > +int screenNum = -1; this is probably going to break in

D10344: Create panel on current screen

hoffmannrobert edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10344 To: hoffmannrobert Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10344: Create panel on current screen

hoffmannrobert created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY In multi-monitor environments panels are always created on screen number 0. There