D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham added a comment. No worries, it sent me down the right path, at least! REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10357: Show high-resolution and vector logos properly in HighDPI mode

cfeck added a comment. Suggesting Qt:AA_EnableHighDpiScaling was my fault; I really should have checked our applications to suggest the correct attribute. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc:

D10357: Show high-resolution and vector logos properly in HighDPI mode

This revision was automatically updated to reflect the committed changes. Closed by commit R102:82e64226c2e6: Show high-resolution and vector logos properly in HighDPI mode (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the summary of this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10357: Show high-resolution and vector logos properly in HighDPI mode

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma, davidedmundson Cc: davidedmundson, broulik, cfeck, plasma-devel, ZrenBot, progwolff,

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham updated this revision to Diff 26699. ngraham added a comment. Simplify the code and address review comments REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10357?vs=26685=26699 BRANCH master REVISION DETAIL

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham marked 4 inline comments as done. ngraham added inline comments. INLINE COMMENTS > broulik wrote in Module.cpp:145 > Did you check how it behaves with a distro-provided pixmap? I fear it would > become tiny. I don't think we have any kind of `@2x` support for that Yes, it still works

D10357: Show high-resolution and vector logos properly in HighDPI mode

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:40 > also it would need to be called before the QApplication constructor Never did that, app.setAttribute(Qt::AA_UseHighDpiPixmaps, true); works just fine and the docs also don't mention it REPOSITORY R102

D10357: Show high-resolution and vector logos properly in HighDPI mode

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in Module.cpp:145 > Did you check how it behaves with a distro-provided pixmap? I fear it would > become tiny. I don't think we have any kind of `@2x` support for that once you have UseHighDpiPixmaps you won't need this

D10357: Show high-resolution and vector logos properly in HighDPI mode

broulik added inline comments. INLINE COMMENTS > Module.cpp:145 > } else { > logo = QPixmap(logoPath); > } Did you check how it behaves with a distro-provided pixmap? I fear it would become tiny. I don't think we have any kind of `@2x` support for that > main.cpp:2 > > +

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham edited the test plan for this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D10357 To: ngraham, #plasma Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10357: Show high-resolution and vector logos properly in HighDPI mode

ngraham created this revision. ngraham added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 388633 Take the device pixel ratio into consideration